Skip to content

Commit

Permalink
Fix #5918
Browse files Browse the repository at this point in the history
The method clean_dashboard_address will also return an empty string. In this case the start_address should be used which will account for the "host" parameter used when specifying a Cluster

This will fix the bug a firewall popup will be created even if `Localcluster(host=localhost)` is specified
  • Loading branch information
maldag committed Sep 10, 2024
1 parent 6eebcfc commit 24cc26d
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion distributed/node.py
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ def start_http_server(
http_addresses = clean_dashboard_address(dashboard_address or default_port)

for http_address in http_addresses:
if http_address["address"] is None:
if http_address["address"] is None or http_address["address"] == '':
address = self._start_address
if isinstance(address, (list, tuple)):
address = address[0]
Expand Down

0 comments on commit 24cc26d

Please sign in to comment.