Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add back LocalCluster.__repr__ #2732

Merged
merged 1 commit into from
May 29, 2019
Merged

Add back LocalCluster.__repr__ #2732

merged 1 commit into from
May 29, 2019

Conversation

lesteve
Copy link
Member

@lesteve lesteve commented May 29, 2019 •
edited
Loading

LocalCluster.__repr__ was removed (I would guess inadvertently) in #2675 where SpecCluster was added.

Inside an IPython console on master:

In [1]: from distributed import LocalCluster 
   ...: cluster = LocalCluster(n_workers=2) 
   ...: cluster                                                                                                                                                                    
Out[1]: SpecCluster('tcp://127.0.0.1:42717', workers=2)

On this PR:

In [1]: from distributed import LocalCluster 
   ...: cluster = LocalCluster(n_workers=2) 
   ...: cluster                                                                                                                                                                    
Out[1]: LocalCluster('tcp://127.0.0.1:43065', workers=2, ncores=4)

Let me know if you'd like me to add a test.

Note: this does not matter at all inside a Jupyter notebook (or Jupyter lab) because the fancy cluster widget is shown rather than __repr__.

@lesteve
Add back LocalCluster.__repr__.
10e1e36 
LocalCluster.__repr__ was removed in dask#2675.
@lesteve lesteve force-pushed the reinstate-localcluster-repr branch from f04ec6c to 10e1e36 Compare May 29, 2019 17:08
@mrocklin mrocklin merged commit 4e3ba76 into dask:master May 29, 2019
@mrocklin
Copy link
Member

Thanks @lesteve ! Sorry for the changes lately. I hope that things calm down again in a couple weeks.

calebho pushed a commit to calebho/distributed that referenced this pull request May 29, 2019
@lesteve @calebho
Add back LocalCluster.__repr__. (dask#2732)
a3ca788 
LocalCluster.__repr__ was removed in dask#2675.
@lesteve lesteve deleted the reinstate-localcluster-repr branch June 6, 2019 12:22
muammar added a commit to muammar/distributed that referenced this pull request Jun 12, 2019
@muammar
Merge remote-tracking branch 'upstream/master'
bd57526 
* upstream/master: (58 commits)
  Add unknown pytest markers (dask#2764)
  Delay lookup of allowed failures. (dask#2761)
  Change address -> worker in ColumnDataSource for nbytes plot (dask#2755)
  Remove module state in Prometheus Handlers (dask#2760)
  Add stress test for UCX (dask#2759)
  Add nanny logs (dask#2744)
  Move some of the adaptive logic into the scheduler (dask#2735)
  Add SpecCluster.new_worker_spec method (dask#2751)
  Worker dashboard fixes (dask#2747)
  Add async context managers to scheduler/worker classes (dask#2745)
  Fix the resource key representation before sending graphs (dask#2716) (dask#2733)
  Allow user to configure whether workers are daemon. (dask#2739)
  Pin pytest >=4 with pip in appveyor and python 3.5 (dask#2737)
  Add Experimental UCX Comm (dask#2591)
  Close nannies gracefully (dask#2731)
  add kwargs to progressbars (dask#2638)
  Add back LocalCluster.__repr__. (dask#2732)
  Move bokeh module to dashboard (dask#2724)
  Close clusters at exit (dask#2730)
  Add SchedulerPlugin TaskState example (dask#2622)
  ...
muammar added a commit to muammar/distributed that referenced this pull request Jul 18, 2019
@muammar
Merge remote-tracking branch 'upstream/master'
ee6df1a 
* upstream/master: (43 commits)
  Add unknown pytest markers (dask#2764)
  Delay lookup of allowed failures. (dask#2761)
  Change address -> worker in ColumnDataSource for nbytes plot (dask#2755)
  Remove module state in Prometheus Handlers (dask#2760)
  Add stress test for UCX (dask#2759)
  Add nanny logs (dask#2744)
  Move some of the adaptive logic into the scheduler (dask#2735)
  Add SpecCluster.new_worker_spec method (dask#2751)
  Worker dashboard fixes (dask#2747)
  Add async context managers to scheduler/worker classes (dask#2745)
  Fix the resource key representation before sending graphs (dask#2716) (dask#2733)
  Allow user to configure whether workers are daemon. (dask#2739)
  Pin pytest >=4 with pip in appveyor and python 3.5 (dask#2737)
  Add Experimental UCX Comm (dask#2591)
  Close nannies gracefully (dask#2731)
  add kwargs to progressbars (dask#2638)
  Add back LocalCluster.__repr__. (dask#2732)
  Move bokeh module to dashboard (dask#2724)
  Close clusters at exit (dask#2730)
  Add SchedulerPlugin TaskState example (dask#2622)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lesteve @mrocklin