Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default branch from master to main #4495

Merged
merged 2 commits into from
Mar 8, 2021

Conversation

jsignell
Copy link
Member

@jsignell jsignell commented Feb 9, 2021

I'm realizing that doing distributed and dask at the same time is unfeasible since it'll mean that the tests never pass. I am going to split this up into just the distributed part.

@jakirkham
Copy link
Member

Just a note, we might want to add main to pip install commands that do development installs that are not otherwise specifying a branch. We needed to do this for zict recently as noted in PR ( #4499 )

@jsignell
Copy link
Member Author

Thanks @jakirkham. I just tried pip installing from git without specifying the branch and it seemed to work fine.

conda create -n test pip python=3.7
conda activate test
pip install git+https://github.com/dask/zict.git

@jakirkham
Copy link
Member

Interesting. Well here is the CI failure we saw

https://github.com/dask/distributed/runs/1868031469

@jakirkham
Copy link
Member

Maybe a non-zero exit code is being set (even though it happens to work)?

@jsignell
Copy link
Member Author

Definitely the windows part of #4499 replacing master with main needed to happen. I am just wondering if the travis part did.

@jakirkham
Copy link
Member

Right was wondering if that happened when running locally

@jsignell
Copy link
Member Author

jsignell commented Mar 8, 2021

I just rebased and I expect this to pass.

Copy link
Member

@jrbourbeau jrbourbeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jsignell. Given the recent release, and no reported issues with the branch name change in other dask/* repos, I think we're in a good place to merge this (and the corresponding PR in dask/dask) soon. I'll comment over in the community issue just to give people a heads up

docs/release-procedure.md Show resolved Hide resolved
@jsignell
Copy link
Member Author

jsignell commented Mar 8, 2021

I think the failure is unrelated, so this should be good to merge.

Copy link
Member

@jrbourbeau jrbourbeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jsignell!

@jrbourbeau jrbourbeau merged commit 6f95c63 into dask:master Mar 8, 2021
@jakirkham
Copy link
Member

jakirkham commented Mar 8, 2021

What's the ETA on fixing the Dask branch as well? We need to update some CI environments and would ideally like to make this change once

Edit: Following up in PR ( dask/dask#7198 (comment) )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants