Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Work/fix firewall for localhost #8868

Merged
merged 13 commits into from
Sep 12, 2024
Merged

Work/fix firewall for localhost #8868

merged 13 commits into from
Sep 12, 2024

Commits on Sep 10, 2024

  1. Revert Split Tokenize 

    This is not included in 2024.4.8 ! So code would not work
    @maldag
    maldag committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    6eebcfc View commit details
    Browse the repository at this point in the history

  2. Fix dask#5918 

    The method clean_dashboard_address will also return an empty string. In this case the start_address should be used which will account for the "host" parameter used when specifying a Cluster

This will fix the bug a firewall popup will be created even if `Localcluster(host=localhost)` is specified
    @maldag
    maldag committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    24cc26d View commit details
    Browse the repository at this point in the history

  3. Revert "Revert Split Tokenize" 

    This reverts commit 6eebcfc.
    @maldag
    maldag committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    226b860 View commit details
    Browse the repository at this point in the history

  4. Linting / pre-commit hooks (pull_request)

    @maldag
    maldag committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    9ffcb8d View commit details
    Browse the repository at this point in the history

  5. Specify defaultcase for dashboard address 

    Iff the dashboard should listen to all interfaces this should be expressed here since empty strings should respect the given host argument
    @maldag
    maldag committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    9cd91a7 View commit details
    Browse the repository at this point in the history

  6. pr linting

    @maldag
    maldag committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    9357915 View commit details
    Browse the repository at this point in the history

  7. fix for 9cd91a7

    @maldag
    maldag committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    cf3ac82 View commit details
    Browse the repository at this point in the history

  8. Revert "fix for 9cd91a7" 

    This reverts commit cf3ac82.
    @maldag
    maldag committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    90f30d5 View commit details
    Browse the repository at this point in the history

  9. Fix expected host binding for dashboard 

    If None is given to dashboard_address, the binding should now take the given parameter on "host" if set.
    @maldag
    maldag committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    8a77345 View commit details
    Browse the repository at this point in the history

  10. fix linting

    @maldag
    maldag committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    cca2b1b View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2024

  1. Fix test for new behaviour

    @maldag
    maldag committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    5db15c5 View commit details
    Browse the repository at this point in the history

  2. Add documentation for LocalCluster

    @maldag
    maldag committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    21fdf78 View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2024

  1. Update distributed/deploy/local.py 

    Co-authored-by: Hendrik Makait <hendrik@makait.com>
    @maldag @hendrikmakait
    maldag and hendrikmakait authored Sep 12, 2024
    Configuration menu
    Copy the full SHA
    cb9f62c View commit details
    Browse the repository at this point in the history