Fix setting environment variables #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As noted in dask#68 (comment), library charts should avoid setting `hub.extraEnv` as a list, since it's liable to be overwritten by users. This avoids that by doing a bit more work in Python in the `hub.extraConfig`.
|
I tested this out manually and it seems to work. Planning to merge this in a couple hours. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noted by @consideRatio in
#68 (comment),
library charts should avoid setting
hub.extraEnvas a list, since it'sliable to be overwritten by users.
This avoids that by doing a bit more work in Python in the
hub.extraConfig.