Skip to content

Commit

Permalink
Increase timeout waiting for job run to 1 day (#786)
Browse files Browse the repository at this point in the history
## Changes

It's not uncommon for job runs to take more than 2 hours. On the client
side, we should not stop waiting for a job to complete if it is
intentionally running for a long time. If a job isn't supposed to run
this long, the user can specify a run timeout in the job specification
itself.

## Tests

n/a
  • Loading branch information
pietern authored Sep 19, 2023
1 parent 43e2eef commit 3a812a6
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion bundle/run/job.go
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ func (o *JobOptions) toPayload(jobID int64) (*jobs.RunNow, error) {
}

// Default timeout for waiting for a job run to complete.
var jobRunTimeout time.Duration = 2 * time.Hour
var jobRunTimeout time.Duration = 24 * time.Hour

type jobRunner struct {
key
Expand Down

0 comments on commit 3a812a6

Please sign in to comment.