-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use dynamic configuration model in bundles #1098
Commits on Oct 31, 2023
-
Configuration menu - View commit details
-
Copy full SHA for ab894fa - Browse repository at this point
Copy the full SHA ab894faView commit details -
Configuration menu - View commit details
-
Copy full SHA for d23e201 - Browse repository at this point
Copy the full SHA d23e201View commit details -
Configuration menu - View commit details
-
Copy full SHA for 36ea807 - Browse repository at this point
Copy the full SHA 36ea807View commit details -
Configuration menu - View commit details
-
Copy full SHA for b9191a4 - Browse repository at this point
Copy the full SHA b9191a4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7968bcb - Browse repository at this point
Copy the full SHA 7968bcbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9b1ed86 - Browse repository at this point
Copy the full SHA 9b1ed86View commit details -
Configuration menu - View commit details
-
Copy full SHA for effb185 - Browse repository at this point
Copy the full SHA effb185View commit details
Commits on Nov 1, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 314ab30 - Browse repository at this point
Copy the full SHA 314ab30View commit details
Commits on Nov 15, 2023
-
Configuration menu - View commit details
-
Copy full SHA for d9d71c3 - Browse repository at this point
Copy the full SHA d9d71c3View commit details -
Configuration menu - View commit details
-
Copy full SHA for bacac76 - Browse repository at this point
Copy the full SHA bacac76View commit details -
Configuration menu - View commit details
-
Copy full SHA for 33f5e75 - Browse repository at this point
Copy the full SHA 33f5e75View commit details -
Configuration menu - View commit details
-
Copy full SHA for e7091f5 - Browse repository at this point
Copy the full SHA e7091f5View commit details -
Configuration menu - View commit details
-
Copy full SHA for bf54271 - Browse repository at this point
Copy the full SHA bf54271View commit details
Commits on Nov 24, 2023
-
Configuration menu - View commit details
-
Copy full SHA for a68f134 - Browse repository at this point
Copy the full SHA a68f134View commit details -
Configuration menu - View commit details
-
Copy full SHA for a93b508 - Browse repository at this point
Copy the full SHA a93b508View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1dad855 - Browse repository at this point
Copy the full SHA 1dad855View commit details -
Configuration menu - View commit details
-
Copy full SHA for 41658d4 - Browse repository at this point
Copy the full SHA 41658d4View commit details -
Configuration menu - View commit details
-
Copy full SHA for c8f02dc - Browse repository at this point
Copy the full SHA c8f02dcView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0d2d4b8 - Browse repository at this point
Copy the full SHA 0d2d4b8View commit details
Commits on Dec 18, 2023
-
Configuration menu - View commit details
-
Copy full SHA for ca5d5d4 - Browse repository at this point
Copy the full SHA ca5d5d4View commit details -
Configuration menu - View commit details
-
Copy full SHA for f18ba50 - Browse repository at this point
Copy the full SHA f18ba50View commit details -
Configuration menu - View commit details
-
Copy full SHA for f7b3290 - Browse repository at this point
Copy the full SHA f7b3290View commit details -
Configuration menu - View commit details
-
Copy full SHA for 21006e5 - Browse repository at this point
Copy the full SHA 21006e5View commit details
Commits on Dec 20, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 97908b6 - Browse repository at this point
Copy the full SHA 97908b6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4543d2d - Browse repository at this point
Copy the full SHA 4543d2dView commit details -
Functionality to walk a config.Value tree
This change adds: * A `config.Walk` function to walk a configuration tree * A `config.Path` type to represent a value's path inside a tree * Functions to create a `config.Path` from a string, or convert one to a string
Configuration menu - View commit details
-
Copy full SHA for 875454d - Browse repository at this point
Copy the full SHA 875454dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 89cae7c - Browse repository at this point
Copy the full SHA 89cae7cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5695e03 - Browse repository at this point
Copy the full SHA 5695e03View commit details -
Configuration menu - View commit details
-
Copy full SHA for ad3b62b - Browse repository at this point
Copy the full SHA ad3b62bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4347007 - Browse repository at this point
Copy the full SHA 4347007View commit details -
Configuration menu - View commit details
-
Copy full SHA for bd64d1d - Browse repository at this point
Copy the full SHA bd64d1dView commit details
Commits on Dec 21, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 962fa96 - Browse repository at this point
Copy the full SHA 962fa96View commit details
Commits on Dec 22, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 40e1425 - Browse repository at this point
Copy the full SHA 40e1425View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9ee9233 - Browse repository at this point
Copy the full SHA 9ee9233View commit details -
Rename libs/config -> libs/dyn
The name "dynamic value", or "dyn" for short, is more descriptive than the opaque "config". Also, it conveniently does not alias with other packages in the repository, or (popular ones) elsewhere.
Configuration menu - View commit details
-
Copy full SHA for fb7ec6b - Browse repository at this point
Copy the full SHA fb7ec6bView commit details -
Configuration menu - View commit details
-
Copy full SHA for b71d8d4 - Browse repository at this point
Copy the full SHA b71d8d4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8fc3ab5 - Browse repository at this point
Copy the full SHA 8fc3ab5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3dbadb4 - Browse repository at this point
Copy the full SHA 3dbadb4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8a11cee - Browse repository at this point
Copy the full SHA 8a11ceeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 69370c4 - Browse repository at this point
Copy the full SHA 69370c4View commit details -
Use resource key as name in permissions code
The code relied on the `Name` property being accessible for every resource. This is generally true, but because these property structs are embedded as pointer, they can be nil. This is also why the tests had to initialize the embedded struct to pass. This changes the approach to use the keys from the resource map instead, so that we no longer rely on the non-nil embedded struct. Note: we should evaluate whether we should turn these into values instead of pointers. I don't recall if we get value from them being pointers.
Configuration menu - View commit details
-
Copy full SHA for cdbea58 - Browse repository at this point
Copy the full SHA cdbea58View commit details -
Configuration menu - View commit details
-
Copy full SHA for 21cf860 - Browse repository at this point
Copy the full SHA 21cf860View commit details
Commits on Dec 27, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 643ae8d - Browse repository at this point
Copy the full SHA 643ae8dView commit details
Commits on Jan 3, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 892b344 - Browse repository at this point
Copy the full SHA 892b344View commit details
Commits on Jan 4, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 68135cb - Browse repository at this point
Copy the full SHA 68135cbView commit details -
Configuration menu - View commit details
-
Copy full SHA for b50cc8a - Browse repository at this point
Copy the full SHA b50cc8aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2f36c7e - Browse repository at this point
Copy the full SHA 2f36c7eView commit details -
Configuration menu - View commit details
-
Copy full SHA for aa19b48 - Browse repository at this point
Copy the full SHA aa19b48View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0213861 - Browse repository at this point
Copy the full SHA 0213861View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8f3cd2e - Browse repository at this point
Copy the full SHA 8f3cd2eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4470722 - Browse repository at this point
Copy the full SHA 4470722View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1cf75ee - Browse repository at this point
Copy the full SHA 1cf75eeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 83fb21c - Browse repository at this point
Copy the full SHA 83fb21cView commit details -
Configuration menu - View commit details
-
Copy full SHA for d80a8ce - Browse repository at this point
Copy the full SHA d80a8ceView commit details -
Configuration menu - View commit details
-
Copy full SHA for b825ccd - Browse repository at this point
Copy the full SHA b825ccdView commit details -
Configuration menu - View commit details
-
Copy full SHA for fab40b1 - Browse repository at this point
Copy the full SHA fab40b1View commit details
Commits on Jan 10, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 2ab8065 - Browse repository at this point
Copy the full SHA 2ab8065View commit details -
Configuration menu - View commit details
-
Copy full SHA for 47eb229 - Browse repository at this point
Copy the full SHA 47eb229View commit details
Commits on Jan 12, 2024
-
Configuration menu - View commit details
-
Copy full SHA for c9330a4 - Browse repository at this point
Copy the full SHA c9330a4View commit details
Commits on Jan 17, 2024
-
Configuration menu - View commit details
-
Copy full SHA for b3113d6 - Browse repository at this point
Copy the full SHA b3113d6View commit details
Commits on Jan 19, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 335d3de - Browse repository at this point
Copy the full SHA 335d3deView commit details
Commits on Jan 23, 2024
-
Configuration menu - View commit details
-
Copy full SHA for b9ea101 - Browse repository at this point
Copy the full SHA b9ea101View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9000bcb - Browse repository at this point
Copy the full SHA 9000bcbView commit details -
Configuration menu - View commit details
-
Copy full SHA for ab42361 - Browse repository at this point
Copy the full SHA ab42361View commit details
Commits on Jan 24, 2024
-
Configuration menu - View commit details
-
Copy full SHA for a95be0f - Browse repository at this point
Copy the full SHA a95be0fView commit details -
Add functionality to visit values in
dyn.Value
treeThis change adds the following functions: * `dyn.Get(value, "foo.bar") -> (dyn.Value, error)` * `dyn.Set(value, "foo.bar", newValue) -> (dyn.Value, error)` * `dyn.Map(value, "foo.bar", func) -> (dyn.Value, error)` And equivalent functions that take a previously constructed `dyn.Path`: * `dyn.GetByPath(value, dyn.Path) -> (dyn.Value, error)` * `dyn.SetByPath(value, dyn.Path, newValue) -> (dyn.Value, error)` * `dyn.MapByPath(value, dyn.Path, func) -> (dyn.Value, error)` Whenever the "set" and "map" functions need to change a value, they return a new `dyn.Value` such that the input value is never changed.
Configuration menu - View commit details
-
Copy full SHA for d0d7536 - Browse repository at this point
Copy the full SHA d0d7536View commit details -
Add
dynvar
package for variable resolution with adyn.Value
treeThis is the `dyn` counterpart to the `bundle/config/interpolation` package. It relies on the paths in `${foo.bar}` being valid `dyn.Path` instances. It leverages `dyn.Walk` to get a complete picture of all variable references and uses `dyn.Get` to retrieve values pointed to by variable references. # Please enter the commit message for your changes. Lines starting # with '#' will be ignored, and an empty message aborts the commit. # # On branch dynvar # Changes to be committed: # new file: libs/dyn/dynvar/lookup.go # new file: libs/dyn/dynvar/lookup_test.go # new file: libs/dyn/dynvar/ref.go # new file: libs/dyn/dynvar/ref_test.go # new file: libs/dyn/dynvar/resolve.go # new file: libs/dyn/dynvar/resolve_test.go # # Untracked files: # extra/ #
Configuration menu - View commit details
-
Copy full SHA for af0e3e2 - Browse repository at this point
Copy the full SHA af0e3e2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 37bd8f1 - Browse repository at this point
Copy the full SHA 37bd8f1View commit details -
Configuration menu - View commit details
-
Copy full SHA for a7348d5 - Browse repository at this point
Copy the full SHA a7348d5View commit details -
Configuration menu - View commit details
-
Copy full SHA for b739338 - Browse repository at this point
Copy the full SHA b739338View commit details -
Configuration menu - View commit details
-
Copy full SHA for a20a7f9 - Browse repository at this point
Copy the full SHA a20a7f9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 36eb46e - Browse repository at this point
Copy the full SHA 36eb46eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 764489e - Browse repository at this point
Copy the full SHA 764489eView commit details
Commits on Jan 25, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 48e2737 - Browse repository at this point
Copy the full SHA 48e2737View commit details -
Configuration menu - View commit details
-
Copy full SHA for b6ade6c - Browse repository at this point
Copy the full SHA b6ade6cView commit details
Commits on Jan 31, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 0b79685 - Browse repository at this point
Copy the full SHA 0b79685View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1b70822 - Browse repository at this point
Copy the full SHA 1b70822View commit details -
Configuration menu - View commit details
-
Copy full SHA for 71f326f - Browse repository at this point
Copy the full SHA 71f326fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2dec864 - Browse repository at this point
Copy the full SHA 2dec864View commit details
Commits on Feb 2, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 1fbed61 - Browse repository at this point
Copy the full SHA 1fbed61View commit details
Commits on Feb 5, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 01a8b20 - Browse repository at this point
Copy the full SHA 01a8b20View commit details -
Configuration menu - View commit details
-
Copy full SHA for fc9c31c - Browse repository at this point
Copy the full SHA fc9c31cView commit details -
Configuration menu - View commit details
-
Copy full SHA for cdcf875 - Browse repository at this point
Copy the full SHA cdcf875View commit details -
Configuration menu - View commit details
-
Copy full SHA for 055a10e - Browse repository at this point
Copy the full SHA 055a10eView commit details -
Configuration menu - View commit details
-
Copy full SHA for afd7450 - Browse repository at this point
Copy the full SHA afd7450View commit details -
Configuration menu - View commit details
-
Copy full SHA for b6b3e07 - Browse repository at this point
Copy the full SHA b6b3e07View commit details -
Configuration menu - View commit details
-
Copy full SHA for 20d5380 - Browse repository at this point
Copy the full SHA 20d5380View commit details -
Configuration menu - View commit details
-
Copy full SHA for c445d19 - Browse repository at this point
Copy the full SHA c445d19View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6b78191 - Browse repository at this point
Copy the full SHA 6b78191View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9c88a7e - Browse repository at this point
Copy the full SHA 9c88a7eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 36666d8 - Browse repository at this point
Copy the full SHA 36666d8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6b5fcb7 - Browse repository at this point
Copy the full SHA 6b5fcb7View commit details
Commits on Feb 6, 2024
-
Ensure every variable reference is passed to lookup function
References to keys that themselves are also variable references were shortcircuited in the previous approach. This meant that certain fields were resolved even if the lookup function would have instructed to skip resolution. To fix this we separate memoization of resolved variable references from memoization of lookups. Now, every variable reference is passed through the lookup function.
Configuration menu - View commit details
-
Copy full SHA for eb0b6a2 - Browse repository at this point
Copy the full SHA eb0b6a2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 49b9681 - Browse repository at this point
Copy the full SHA 49b9681View commit details -
Configuration menu - View commit details
-
Copy full SHA for ac07608 - Browse repository at this point
Copy the full SHA ac07608View commit details -
Configuration menu - View commit details
-
Copy full SHA for 98f8344 - Browse repository at this point
Copy the full SHA 98f8344View commit details -
Configuration menu - View commit details
-
Copy full SHA for 44e7914 - Browse repository at this point
Copy the full SHA 44e7914View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4f2c288 - Browse repository at this point
Copy the full SHA 4f2c288View commit details -
Configuration menu - View commit details
-
Copy full SHA for f7b3253 - Browse repository at this point
Copy the full SHA f7b3253View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5f85d59 - Browse repository at this point
Copy the full SHA 5f85d59View commit details
Commits on Feb 7, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 7bf5abf - Browse repository at this point
Copy the full SHA 7bf5abfView commit details -
Zero destination struct in
convert.ToTyped
Not doing this means that the output struct is not a true representation of the `dyn.Value` and unrepresentable state (e.g. unexported fields) can be carried over across `convert.ToTyped` calls.
Configuration menu - View commit details
-
Copy full SHA for 9b60240 - Browse repository at this point
Copy the full SHA 9b60240View commit details -
Configuration menu - View commit details
-
Copy full SHA for e330189 - Browse repository at this point
Copy the full SHA e330189View commit details -
Configuration menu - View commit details
-
Copy full SHA for 879959a - Browse repository at this point
Copy the full SHA 879959aView commit details -
Configuration menu - View commit details
-
Copy full SHA for d5c710f - Browse repository at this point
Copy the full SHA d5c710fView commit details -
Configuration menu - View commit details
-
Copy full SHA for f97fd5f - Browse repository at this point
Copy the full SHA f97fd5fView commit details
Commits on Feb 8, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 3cd824a - Browse repository at this point
Copy the full SHA 3cd824aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4406361 - Browse repository at this point
Copy the full SHA 4406361View commit details -
Configuration menu - View commit details
-
Copy full SHA for 061d57b - Browse repository at this point
Copy the full SHA 061d57bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 61bc57e - Browse repository at this point
Copy the full SHA 61bc57eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 245b481 - Browse repository at this point
Copy the full SHA 245b481View commit details -
Configuration menu - View commit details
-
Copy full SHA for 978f313 - Browse repository at this point
Copy the full SHA 978f313View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7154f36 - Browse repository at this point
Copy the full SHA 7154f36View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1c1fc57 - Browse repository at this point
Copy the full SHA 1c1fc57View commit details -
Configuration menu - View commit details
-
Copy full SHA for 36646e8 - Browse repository at this point
Copy the full SHA 36646e8View commit details
Commits on Feb 13, 2024
-
Retain partially valid structs in
convert.Normalize
Before this change, any error in a subtree would cause the entire subtree to be dropped from the output. This is not ideal when debugging, so instead we drop only the values that cannot be normalized. Note that this doesn't change behavior if the caller is properly checking the returned diagnostics for errors.
Configuration menu - View commit details
-
Copy full SHA for d1f558f - Browse repository at this point
Copy the full SHA d1f558fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 160c371 - Browse repository at this point
Copy the full SHA 160c371View commit details -
Configuration menu - View commit details
-
Copy full SHA for 727beca - Browse repository at this point
Copy the full SHA 727becaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 938423f - Browse repository at this point
Copy the full SHA 938423fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8738ad6 - Browse repository at this point
Copy the full SHA 8738ad6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1a45a8c - Browse repository at this point
Copy the full SHA 1a45a8cView commit details -
Configuration menu - View commit details
-
Copy full SHA for be21195 - Browse repository at this point
Copy the full SHA be21195View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0c47f4d - Browse repository at this point
Copy the full SHA 0c47f4dView commit details -
Configuration menu - View commit details
-
Copy full SHA for f8e701d - Browse repository at this point
Copy the full SHA f8e701dView commit details
Commits on Feb 14, 2024
-
Configuration menu - View commit details
-
Copy full SHA for b72c75d - Browse repository at this point
Copy the full SHA b72c75dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 60bd1ec - Browse repository at this point
Copy the full SHA 60bd1ecView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0d59f4f - Browse repository at this point
Copy the full SHA 0d59f4fView commit details
Commits on Feb 15, 2024
-
Add option to include fields present in the type but not in the value
This feature supports variable lookups in a `dyn.Value` that are present in the type but haven't been initialized with a value. For example: `${bundle.git.origin_url}` is present in the `dyn.Value` only if it was assigned a value. If it wasn't assigned a value it should resolve to the empty string. This normalization option, when set, ensures that all fields that are represented in the specified type are present in the return value.
Configuration menu - View commit details
-
Copy full SHA for 2fd8f7e - Browse repository at this point
Copy the full SHA 2fd8f7eView commit details -
Configuration menu - View commit details
-
Copy full SHA for e6fc04f - Browse repository at this point
Copy the full SHA e6fc04fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8774a96 - Browse repository at this point
Copy the full SHA 8774a96View commit details -
Configuration menu - View commit details
-
Copy full SHA for c7ab94b - Browse repository at this point
Copy the full SHA c7ab94bView commit details -
Configuration menu - View commit details
-
Copy full SHA for c2cd815 - Browse repository at this point
Copy the full SHA c2cd815View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6495c10 - Browse repository at this point
Copy the full SHA 6495c10View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3521d02 - Browse repository at this point
Copy the full SHA 3521d02View commit details -
Configuration menu - View commit details
-
Copy full SHA for dcc4990 - Browse repository at this point
Copy the full SHA dcc4990View commit details -
Configuration menu - View commit details
-
Copy full SHA for 22f8a8e - Browse repository at this point
Copy the full SHA 22f8a8eView commit details
Commits on Feb 16, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 9d17138 - Browse repository at this point
Copy the full SHA 9d17138View commit details -
Configuration menu - View commit details
-
Copy full SHA for 184907c - Browse repository at this point
Copy the full SHA 184907cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2fa4e11 - Browse repository at this point
Copy the full SHA 2fa4e11View commit details -
Configuration menu - View commit details
-
Copy full SHA for b740ec7 - Browse repository at this point
Copy the full SHA b740ec7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4e5605f - Browse repository at this point
Copy the full SHA 4e5605fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 89961be - Browse repository at this point
Copy the full SHA 89961beView commit details