Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add
bundle debug terraform
command #1294Add
bundle debug terraform
command #1294Changes from all commits
c3ca75d
e8ec958
aff7024
9135426
d99a003
8a3b0b7
c157a5c
f6142ce
91924ed
55c7808
1e549a4
70334a5
20ff8e1
58bbd71
c5df7af
51175c9
7e42269
92e5cef
5f4ddb4
9e84685
e10464f
cd31b66
d38d946
8884a41
d99642f
7413253
138a9e1
d921a82
d157a2c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not a hard error? If someone sets these env vars, they intend to use them. Mistakes are ignored.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Environment varialbes in the terminals can have a long timespan, and we can't change them after the initial setup.
One edge case is when users uninstall the extension. The variables will stick in the persistent terminal sessions utill users re-create terminals. Since we don't copy the dependencies and point env vars to the internals of the installed extensions, after the uninstall the variables will point to the place that no longer exist. We can copy dependencies to
.databricks
folder for each project, but I don't think it's worth the hassleThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How does this tie in with Databricks Terminals? If these are only set in those then we don't have to bother with long lifetimes of env vars in terminals.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For my knowledge, updating the extensions requires reloading the IDE, and then reloading the IDE should refresh the env vars right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reloading VSCode doesn't restart terminals, they are persistent (at least by default), and so the env vars also persist.
We've not yet made a decision about "Databricks Terminal". We can change the logic here afterwards though