-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Return diagnostics from config.Load
#1324
Merged
Merged
Commits on Mar 26, 2024
-
Move path field to bundle type
The bundle path was previously stored on the `config.Root` type under the assumption that the first configuration file being loaded would set it. This is slightly counterintuitive and we know what the path is upon construction of the bundle. The new location for this property reflects this.
Configuration menu - View commit details
-
Copy full SHA for 2adc677 - Browse repository at this point
Copy the full SHA 2adc677View commit details -
Configuration menu - View commit details
-
Copy full SHA for f48cf03 - Browse repository at this point
Copy the full SHA f48cf03View commit details -
Configuration menu - View commit details
-
Copy full SHA for bd14db0 - Browse repository at this point
Copy the full SHA bd14db0View commit details -
Remove support for DATABRICKS_BUNDLE_INCLUDES
PR #604 added functionality to load a bundle without a `databricks.yml` if both the `DATABRICKS_BUNDLE_ROOT` and `DATABRICKS_BUNDLE_INCLUDES` environment variables were set. We never ended up using this in downstream tools so this can be removed.
Configuration menu - View commit details
-
Copy full SHA for 99f027e - Browse repository at this point
Copy the full SHA 99f027eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 503e3e4 - Browse repository at this point
Copy the full SHA 503e3e4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 64a5bed - Browse repository at this point
Copy the full SHA 64a5bedView commit details -
Configuration menu - View commit details
-
Copy full SHA for b79ae8f - Browse repository at this point
Copy the full SHA b79ae8fView commit details
Commits on Mar 27, 2024
-
Make bundle loaders return diagnostics
This is incompatible with the function signature of Cobra's `PreRunE` functions, so this change updates any use of PreRunE to be inlined in the main run function.
Configuration menu - View commit details
-
Copy full SHA for 64111e5 - Browse repository at this point
Copy the full SHA 64111e5View commit details -
Configuration menu - View commit details
-
Copy full SHA for d01334b - Browse repository at this point
Copy the full SHA d01334bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 66b4be3 - Browse repository at this point
Copy the full SHA 66b4be3View commit details -
Configuration menu - View commit details
-
Copy full SHA for d1dd71b - Browse repository at this point
Copy the full SHA d1dd71bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4d494b6 - Browse repository at this point
Copy the full SHA 4d494b6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 93de5c7 - Browse repository at this point
Copy the full SHA 93de5c7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8fff41b - Browse repository at this point
Copy the full SHA 8fff41bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 790103e - Browse repository at this point
Copy the full SHA 790103eView commit details -
Configuration menu - View commit details
-
Copy full SHA for f701924 - Browse repository at this point
Copy the full SHA f701924View commit details
Commits on Mar 28, 2024
-
Configuration menu - View commit details
-
Copy full SHA for a0d8055 - Browse repository at this point
Copy the full SHA a0d8055View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1bccc15 - Browse repository at this point
Copy the full SHA 1bccc15View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.