Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return diagnostics from config.Load #1324

Merged
merged 18 commits into from
Mar 28, 2024
Merged

Return diagnostics from config.Load #1324

merged 18 commits into from
Mar 28, 2024

Commits on Mar 26, 2024

  1. Move path field to bundle type

    The bundle path was previously stored on the `config.Root` type under the
    assumption that the first configuration file being loaded would set it. This is
    slightly counterintuitive and we know what the path is upon construction of the
    bundle. The new location for this property reflects this.
    pietern committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    2adc677 View commit details
    Browse the repository at this point in the history
  2. Path -> RootPath

    pietern committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    f48cf03 View commit details
    Browse the repository at this point in the history
  3. Fix

    pietern committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    bd14db0 View commit details
    Browse the repository at this point in the history
  4. Remove support for DATABRICKS_BUNDLE_INCLUDES

    PR #604 added functionality to load a bundle without a `databricks.yml` if both
    the `DATABRICKS_BUNDLE_ROOT` and `DATABRICKS_BUNDLE_INCLUDES` environment
    variables were set. We never ended up using this in downstream tools so this
    can be removed.
    pietern committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    99f027e View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    503e3e4 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    64a5bed View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    b79ae8f View commit details
    Browse the repository at this point in the history

Commits on Mar 27, 2024

  1. Make bundle loaders return diagnostics

    This is incompatible with the function signature of Cobra's `PreRunE`
    functions, so this change updates any use of PreRunE to be inlined in the main
    run function.
    pietern committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    64111e5 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d01334b View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    66b4be3 View commit details
    Browse the repository at this point in the history
  4. Revert profile move

    pietern committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    d1dd71b View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    4d494b6 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    93de5c7 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    8fff41b View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    790103e View commit details
    Browse the repository at this point in the history
  9. Update comment

    pietern committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    f701924 View commit details
    Browse the repository at this point in the history

Commits on Mar 28, 2024

  1. Configuration menu
    Copy the full SHA
    a0d8055 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    1bccc15 View commit details
    Browse the repository at this point in the history