Added test for negation pattern in sync include exclude section #1637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewnester
commented
Jul 30, 2024
libs/sync/sync_test.go
Outdated
| @@ -67,6 +67,9 @@ func setupFiles(t *testing.T) string { | |||
| err = createFile(sub2, "g.go") | |||
| require.NoError(t, err) | |||
|
|
|||
| err = createFile(sub2, "h.txt") | |||
There was a problem hiding this comment.
I'd recommend creating these files and directories using for loops, to make the code terser.
There was a problem hiding this comment.
@shreyas-goenka we can't really because we need predictable structure and the files are located in different subdirectories so using loops will make it even less readable
There was a problem hiding this comment.
What do you think about simplifying it like this? The file tree structure is a lot more evident in this case.
for p in {
[]string{dir, "a.go"},
[]string{dir, "b.go"},
...
[]string{dir, ".databricks", "e.go"}
...
[]string{dir, "test", "sub1", "f.go"}
} {
testutil.Touch(t, p...)
}
There was a problem hiding this comment.
Yes, that's a good one, thanks!
shreyas-goenka
approved these changes
Jul 31, 2024
andrewnester
added a commit
that referenced
this pull request
Jul 31, 2024
Bundles: * Add resource for UC schemas to DABs ([#1413](#1413)). Internal: * Use dynamic walking to validate unique resource keys ([#1614](#1614)). * Regenerate TF schema ([#1635](#1635)). * Add upgrade and upgrade eager flags to pip install call ([#1636](#1636)). * Added test for negation pattern in sync include exclude section ([#1637](#1637)). * Use precomputed terraform plan for `bundle deploy` ([#1640](#1640)).
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 31, 2024
Bundles: * Add resource for UC schemas to DABs ([#1413](#1413)). Internal: * Use dynamic walking to validate unique resource keys ([#1614](#1614)). * Regenerate TF schema ([#1635](#1635)). * Add upgrade and upgrade eager flags to pip install call ([#1636](#1636)). * Added test for negation pattern in sync include exclude section ([#1637](#1637)). * Use precomputed terraform plan for `bundle deploy` ([#1640](#1640)).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Added test for negation pattern in sync include exclude section