Use the friendly name of service principals when shortening their name #1770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pietern
approved these changes
Sep 13, 2024
There was a problem hiding this comment.
The only risk here is that the display name of SPs is freeform thus not guaranteed to be unique. If we ever have a situation where the multiple SPs have the same display name, the user will run into name conflicts (e.g. for pipelines).
This risk doesn't outweigh the benefit, IMO.
Please TAL at 1 small readability comment.
andrewnester
added a commit
that referenced
this pull request
Sep 18, 2024
CLI: * Added listing cluster filtering for cluster lookups ([#1754](#1754)). Bundles: * Expand library globs relative to the sync root ([#1756](#1756)). * Fixed generated YAML missing 'default' for empty values ([#1765](#1765)). * Use periodic triggers in all templates ([#1739](#1739)). * Use the friendly name of service principals when shortening their name ([#1770](#1770)). * Fixed detecting full syntax variable override which includes type field ([#1775](#1775)). Internal: * Pass copy of `dyn.Path` to callback function ([#1747](#1747)). * Make bundle JSON schema modular with `$defs` ([#1700](#1700)). * Alias variables block in the `Target` struct ([#1748](#1748)). * Add end to end integration tests for bundle JSON schema ([#1726](#1726)). * Fix artifact upload integration tests ([#1767](#1767)). API Changes: * Added `databricks quality-monitors regenerate-dashboard` command. OpenAPI commit d05898328669a3f8ab0c2ecee37db2673d3ea3f7 (2024-09-04) Dependency updates: * Bump golang.org/x/term from 0.23.0 to 0.24.0 ([#1757](#1757)). * Bump golang.org/x/oauth2 from 0.22.0 to 0.23.0 ([#1761](#1761)). * Bump golang.org/x/text from 0.17.0 to 0.18.0 ([#1759](#1759)). * Bump github.com/databricks/databricks-sdk-go from 0.45.0 to 0.46.0 ([#1760](#1760)).
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 18, 2024
Bundles: * Added listing cluster filtering for cluster lookups ([#1754](#1754)). * Expand library globs relative to the sync root ([#1756](#1756)). * Fixed generated YAML missing 'default' for empty values ([#1765](#1765)). * Use periodic triggers in all templates ([#1739](#1739)). * Use the friendly name of service principals when shortening their name ([#1770](#1770)). * Fixed detecting full syntax variable override which includes type field ([#1775](#1775)). Internal: * Pass copy of `dyn.Path` to callback function ([#1747](#1747)). * Make bundle JSON schema modular with `$defs` ([#1700](#1700)). * Alias variables block in the `Target` struct ([#1748](#1748)). * Add end to end integration tests for bundle JSON schema ([#1726](#1726)). * Fix artifact upload integration tests ([#1767](#1767)). API Changes: * Added `databricks quality-monitors regenerate-dashboard` command. OpenAPI commit d05898328669a3f8ab0c2ecee37db2673d3ea3f7 (2024-09-04) Dependency updates: * Bump golang.org/x/term from 0.23.0 to 0.24.0 ([#1757](#1757)). * Bump golang.org/x/oauth2 from 0.22.0 to 0.23.0 ([#1761](#1761)). * Bump golang.org/x/text from 0.17.0 to 0.18.0 ([#1759](#1759)). * Bump github.com/databricks/databricks-sdk-go from 0.45.0 to 0.46.0 ([#1760](#1760)).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Use the friendly name of service principals when shortening their name.
This change is helpful for the prefix in development mode. Instead of adding a prefix like
[dev 1706906c-c0a2-4c25-9f57-3a7aa3cb8123], we'll prefix like[dev my_principal].