Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore flags to original values on test completion #470

Merged
merged 3 commits into from
Jun 14, 2023

Conversation

shreyas-goenka
Copy link
Contributor

@shreyas-goenka shreyas-goenka commented Jun 13, 2023

Changes

This is necessary to avoid test interference.

Tests

Manually.

@shreyas-goenka
Copy link
Contributor Author

Needs more work, some other flags too have incompatible default values wrt to their set methods. See failing PR checks for reference

Copy link
Contributor

@pietern pietern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this LGTM!

internal/helpers.go Outdated Show resolved Hide resolved
@pietern pietern changed the title Restore flag values to original defaults once a test finishes running Restore flags to original values on test completion Jun 14, 2023
@shreyas-goenka shreyas-goenka merged commit 968489d into main Jun 14, 2023
@shreyas-goenka shreyas-goenka deleted the cleanup-flag-defaults branch June 14, 2023 12:53
@pietern pietern mentioned this pull request Jun 15, 2023
pietern added a commit that referenced this pull request Jun 15, 2023
## Changes

CLI:
* Add workspace import-dir command
([#456](#456)).
* Annotate generated commands with OpenAPI package name
([#466](#466)).
* Associate generated commands with command groups
([#475](#475)).
* Disable shell completions for generated commands
([#483](#483)).
* Include [DEFAULT] section header when writing ~/.databrickscfg
([#464](#464)).
* Pass through proxy related environment variables
([#465](#465)).
* Restore flags to original values on test completion
([#470](#470)).
* Update configure command
([#482](#482)).

Dependencies:
* Bump SDK to latest
([#473](#473)).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants