Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add development runs #522
Add development runs #522
Changes from 11 commits
48d6df3
27b2b77
823c868
6414701
bdd2124
7c654ec
b7a80af
567d76d
30667d4
b7c53b2
458a2d0
4762716
15396bc
5a7b556
34a1698
ddcd613
64edf39
35f4d3b
36a6e93
be2dd4f
d221d4d
50b76bb
6b221c0
cbd3068
54a66c0
77fcc92
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Curious: has this run twice in your testing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it would, but I think that may have only happened with
databricks deploy --run
. So I'll remove this.We should actually have a general fix to make sure
w.CurrentUser.Me()
is cached, since it is very very slow and was still being called a second time in some other cases. This could be part of a general initiative to make things a bit faster.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These "PAUSED" strings should be the constant
jobs.PauseStatusPaused
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed. Is that another SDK name that should be changed, btw? :( That doesn't seem like a very idiomatic name.