Add template renderer for Databricks templates #589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and added a test for persistToDisk
shreyas-goenka
changed the title
pietern
reviewed
Jul 20, 2023
| } | ||
|
|
||
| // execute the contents of the file as a template | ||
| content, err := r.executeTemplate(string(contentTemplate)) |
There was a problem hiding this comment.
This means we also pass binaries/non-template files into the template execution.
I'm thinking we may need to revisit a .tmpl extension for templates because files with binary data likely won't parse as a template, or worse, parse as a template and produce some invalid output.
There was a problem hiding this comment.
Doing this as a followup
pietern
approved these changes
Jul 21, 2023
shreyas-goenka
added a commit
that referenced
this pull request
Jul 21, 2023
This reverts commit 02dbac7.
shreyas-goenka
added a commit
that referenced
this pull request
Jul 21, 2023
## Changes Due to a bug in Github UI, #589 got merged without passing the go/fmt formatting checks This PR fixes the formatting which breaks the PR checks
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 27, 2023
Breaking Change: * Require include glob patterns to be explicitly defined ([#602](#602)). Bundles: * Add support for more SDK config options ([#587](#587)). * Add template renderer for Databricks templates ([#589](#589)). * Fix formatting in renderer.go ([#593](#593)). * Fixed python wheel test ([#608](#608)). * Auto detect Python wheel packages and infer build command ([#603](#603)). * Added support for artifacts building for bundles ([#583](#583)). * Add support for cloning repositories ([#544](#544)). * Add regexp compile helper function for templates ([#601](#601)). * Add unit test that raw strings are printed as is ([#599](#599)). Internal: * Fix tests under ./cmd/configure if DATABRICKS_TOKEN is set ([#605](#605)). * Remove dependency on global state in generated commands ([#595](#595)). * Remove dependency on global state for the root command ([#606](#606)). * Add merge_group trigger for build ([#612](#612)). * Added support for build command chaining and error on missing wheel ([#607](#607)). * Add TestAcc prefix to filer test and fix any failing tests ([#611](#611)). * Add url parse helper function for templates ([#600](#600)). * Remove dependency on global state for remaining commands ([#613](#613)). * Update CHANGELOG template ([#588](#588)).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR adds the renderer struct, which is a walker that traverses templates and generates projects from them
Tests
Unit tests