Added OnlyPayload property for method #522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #522 +/- ##
==========================================
- Coverage 18.76% 18.76% -0.01%
==========================================
Files 85 85
Lines 9187 9188 +1
==========================================
Hits 1724 1724
- Misses 7315 7316 +1
Partials 148 148
☔ View full report in Codecov by Sentry. |
pietern
reviewed
Jun 19, 2023
|
@pietern renamed to |
nfx
approved these changes
Jun 19, 2023
| @@ -154,6 +154,10 @@ func (m *Method) IsCrudCreate() bool { | |||
| return m.operation.Crud == "create" | |||
| } | |||
|
|
|||
| func (m *Method) JsonOnly() bool { | |||
There was a problem hiding this comment.
Suggested change
| func (m *Method) JsonOnly() bool { | |
| func (m *Method) IsJsonOnly() bool { |
andrewnester
added a commit
to databricks/cli
that referenced
this pull request
Jun 21, 2023
## Changes Fixed jobs create command to only accept JSON payload. Note: relies on this PR from Go SDK databricks/databricks-sdk-go#522 ## Tests ``` andrew.nester@HFW9Y94129 cli % ./cli jobs create -h Create a new job. Create a new job. Usage: databricks jobs create [flags] Flags: -h, --help help for create --json JSON either inline JSON string or @path/to/file.json with request body (default JSON (0 bytes)) Global Flags: -e, --environment string bundle environment to use (if applicable) --log-file file file to write logs to (default stderr) --log-format type log output format (text or json) (default text) --log-level format log level (default disabled) -o, --output type output type: text or json (default text) -p, --profile string ~/.databrickscfg profile --progress-format format format for progress logs (append, inplace, json) (default default) ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Added OnlyPayload property for method
Tests
make testpassingmake fmtappliedrelevant integration tests applied