Cloud fetch queue and integration #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattdeekay
requested review from
arikfr,
yunbodeng-db and
andrefurlan-db
as code owners
rcypher-databricks
approved these changes
Jun 22, 2023
rcypher-databricks
approved these changes
Jun 27, 2023
mattdeekay
force-pushed
the
cloudfetch-queue
branch
from
2991e36
to
3c4e3ac
Compare
Signed-off-by: Matthew Kim <11141331+mattdeekay@users.noreply.github.com>
Signed-off-by: Matthew Kim <11141331+mattdeekay@users.noreply.github.com>
Signed-off-by: Matthew Kim <11141331+mattdeekay@users.noreply.github.com>
Signed-off-by: Matthew Kim <11141331+mattdeekay@users.noreply.github.com>
Signed-off-by: Matthew Kim <11141331+mattdeekay@users.noreply.github.com>
mattdeekay
force-pushed
the
cloudfetch-queue
branch
from
3c4e3ac
to
504b000
Compare
mattdeekay
commented
Jul 3, 2023
Signed-off-by: Matthew Kim <11141331+mattdeekay@users.noreply.github.com>
mattdeekay
commented
Jul 3, 2023
Signed-off-by: Matthew Kim <11141331+mattdeekay@users.noreply.github.com>
mattdeekay
commented
Jul 3, 2023
Signed-off-by: Matthew Kim <11141331+mattdeekay@users.noreply.github.com>
mattdeekay
force-pushed
the
cloudfetch-queue
branch
from
2ca44a4
to
99dfe8e
Compare
Signed-off-by: Matthew Kim <11141331+mattdeekay@users.noreply.github.com>
mattdeekay
force-pushed
the
cloudfetch-queue
branch
from
99dfe8e
to
9096ccd
Compare
Signed-off-by: Matthew Kim <11141331+mattdeekay@users.noreply.github.com>
Signed-off-by: Matthew Kim <11141331+mattdeekay@users.noreply.github.com>
Merged
susodapop
pushed a commit
to unj1m/databricks-sql-python
that referenced
this pull request
Sep 19, 2023
* Cloud fetch queue and integration Signed-off-by: Matthew Kim <11141331+mattdeekay@users.noreply.github.com> * Enable cloudfetch with direct results Signed-off-by: Matthew Kim <11141331+mattdeekay@users.noreply.github.com> * Typing and style changes Signed-off-by: Matthew Kim <11141331+mattdeekay@users.noreply.github.com> * Client-settable max_download_threads Signed-off-by: Matthew Kim <11141331+mattdeekay@users.noreply.github.com> * Docstrings and comments Signed-off-by: Matthew Kim <11141331+mattdeekay@users.noreply.github.com> * Increase default buffer size bytes to 104857600 Signed-off-by: Matthew Kim <11141331+mattdeekay@users.noreply.github.com> * Move max_download_threads to kwargs of ThriftBackend, fix unit tests Signed-off-by: Matthew Kim <11141331+mattdeekay@users.noreply.github.com> * Fix tests: staticmethod make_arrow_table mock not callable Signed-off-by: Matthew Kim <11141331+mattdeekay@users.noreply.github.com> * cancel_futures in shutdown() only available in python >=3.9.0 Signed-off-by: Matthew Kim <11141331+mattdeekay@users.noreply.github.com> * Black linting Signed-off-by: Matthew Kim <11141331+mattdeekay@users.noreply.github.com> * Fix typing errors Signed-off-by: Matthew Kim <11141331+mattdeekay@users.noreply.github.com> --------- Signed-off-by: Matthew Kim <11141331+mattdeekay@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
ResultSetQueueare moved toutils.pyto avoid circular dependency (thrift_backend.py<>utils.py)ResultSetQueueabstract base class, withResultSetQueueFactoryproducingArrowQueueif result is arrow-based,ArrowQueueagain if column-based, andCloudFetchQueueif url-based.