Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reverting retry behavior on 429s/503s to how it worked in 2.9.3 #349

Merged
merged 1 commit into from
Feb 15, 2024

Conversation

benc-db
Copy link
Collaborator

@benc-db benc-db commented Feb 8, 2024

In version 3 we started accepting Retry-After exactly on 429s/503s, as opposed to using it as a floor for exponential backoff. After consulting with SQL Gateway team, it is best to bring that behavior back. Apologies for the formatting differences, this was automatically performed by VS Code.

Copy link

github-actions bot commented Feb 8, 2024

Thanks for your contribution! To satisfy the DCO policy in our contributing guide every commit message must include a sign-off message. One or more of your commits is missing this message. You can reword previous commit messages with an interactive rebase (git rebase -i main).

1 similar comment
Copy link

github-actions bot commented Feb 8, 2024

Thanks for your contribution! To satisfy the DCO policy in our contributing guide every commit message must include a sign-off message. One or more of your commits is missing this message. You can reword previous commit messages with an interactive rebase (git rebase -i main).

Copy link

Thanks for your contribution! To satisfy the DCO policy in our contributing guide every commit message must include a sign-off message. One or more of your commits is missing this message. You can reword previous commit messages with an interactive rebase (git rebase -i main).

linted

rebased

Signed-off-by: Ben Cassell <ben.cassell@databricks.com>

fixing failing tests
@benc-db benc-db merged commit 2977f70 into main Feb 15, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants