Add a default for retry after #371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ben Cassell <ben.cassell@databricks.com>
benc-db
requested review from
rcypher-databricks,
arikfr,
yunbodeng-db,
andrefurlan-db and
jackyhu-db
as code owners
Signed-off-by: Ben Cassell <ben.cassell@databricks.com>
jackyhu-db
approved these changes
Mar 14, 2024
benc-db
added a commit
that referenced
this pull request
Mar 19, 2024
* Add a default for retry after Signed-off-by: Ben Cassell <ben.cassell@databricks.com> * Applied black formatter Signed-off-by: Ben Cassell <ben.cassell@databricks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we get a 503 without a Retry-After, it can indicate that nginx was responding while app was starting up / shutting down, and may not have a Retry-After set. This causes the connector to bail, which is problematic for dependent projects such as dbt-databricks. Apologies for the autoformat, the only real change is on lines 366-367.