[PECO-1857] Use SSL options with HTTPS connection pool #425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Levko Kravets <levko.ne@gmail.com>
Signed-off-by: Levko Kravets <levko.ne@gmail.com>
Signed-off-by: Levko Kravets <levko.ne@gmail.com>
kravets-levko
temporarily deployed
to
azure-prod
GitHub Actions
Inactive
Signed-off-by: Levko Kravets <levko.ne@gmail.com>
kravets-levko
temporarily deployed
to
azure-prod
GitHub Actions
Inactive
Signed-off-by: Levko Kravets <levko.ne@gmail.com>
kravets-levko
temporarily deployed
to
azure-prod
GitHub Actions
Inactive
Signed-off-by: Levko Kravets <levko.ne@gmail.com>
kravets-levko
temporarily deployed
to
azure-prod
GitHub Actions
Inactive
|
When you make the change please let @benc-db know so he can change his code to adapt. |
kravets-levko
temporarily deployed
to
azure-prod
GitHub Actions
Inactive
kravets-levko
requested review from
rcypher-databricks,
yunbodeng-db,
andrefurlan-db,
jackyhu-db and
benc-db
as code owners
benc-db
reviewed
Aug 22, 2024
benc-db
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue seems to be a regression after #131
SSL options (
_tls_no_verify,_tls_trusted_ca_file,_tls_client_cert_file,_tls_client_cert_key_file,_tls_client_cert_key_password) are not used for requests to Thrift backend: they are just not passed to connection pool