Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to get saved profile from the legacy config #1387

Merged
merged 3 commits into from
Oct 10, 2024

Conversation

ilia-db
Copy link
Contributor

@ilia-db ilia-db commented Oct 9, 2024

Changes

V2 extension currently requires manual action from users if we detect multiple profiles that match the selected target. But in the V1 users might have already disambiguated the profiles, so here we use this inromation to get the saved profile.

Tests

Manually

V2 extension currently requires manual action from users
if we detect multiple profiles that match the selected target.
But in the V1 users might have already disambiguated the profiles,
so here we use this inromation to get the saved profile.
It seems like many users end up on the manual migration page,
this should help us see if that's true or not.
@ilia-db ilia-db merged commit e2fb4a3 into bundle-integ Oct 10, 2024
26 checks passed
@ilia-db ilia-db deleted the ilia-db/improve-multi-profiles branch October 10, 2024 08:46
@github-actions github-actions bot mentioned this pull request Oct 10, 2024
ilia-db added a commit that referenced this pull request Oct 10, 2024
## packages/databricks-vscode
##  (2024-10-10)

* Try to get saved profile from the legacy config (#1387)
([e2fb4a3](e2fb4a3)),
closes
[#1387](#1387)



## packages/databricks-vscode-types
##  (2024-10-10)

---------

Co-authored-by: releasebot <noreply@github.com>
Co-authored-by: Ilia Babanov <ilia.babanov@databricks.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants