-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Try to get saved profile from the legacy config #1387
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
V2 extension currently requires manual action from users if we detect multiple profiles that match the selected target. But in the V1 users might have already disambiguated the profiles, so here we use this inromation to get the saved profile.
fjakobs
approved these changes
Oct 9, 2024
ilia-db
had a problem deploying
to
azure-prod-usr
October 9, 2024 13:38
— with
GitHub Actions
Failure
It seems like many users end up on the manual migration page, this should help us see if that's true or not.
ilia-db
had a problem deploying
to
azure-prod-usr
October 9, 2024 15:40
— with
GitHub Actions
Failure
ilia-db
had a problem deploying
to
azure-prod-usr
October 9, 2024 15:41
— with
GitHub Actions
Failure
ilia-db
had a problem deploying
to
azure-prod-usr
October 9, 2024 15:51
— with
GitHub Actions
Failure
ilia-db
temporarily deployed
to
azure-prod-usr
October 10, 2024 08:09
— with
GitHub Actions
Inactive
Merged
ilia-db
added a commit
that referenced
this pull request
Oct 10, 2024
## packages/databricks-vscode ## (2024-10-10) * Try to get saved profile from the legacy config (#1387) ([e2fb4a3](e2fb4a3)), closes [#1387](#1387) ## packages/databricks-vscode-types ## (2024-10-10) --------- Co-authored-by: releasebot <noreply@github.com> Co-authored-by: Ilia Babanov <ilia.babanov@databricks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
V2 extension currently requires manual action from users if we detect multiple profiles that match the selected target. But in the V1 users might have already disambiguated the profiles, so here we use this inromation to get the saved profile.
Tests
Manually