Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid a warning in covid_trends_job.py #9

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Avoid a warning in covid_trends_job.py #9

wants to merge 1 commit into from

Conversation

lennartkats-db
Copy link

@lennartkats-db lennartkats-db commented Oct 26, 2022 •
edited
Loading

Using a PEP 484 "# type: ignore" annotation

I do wonder if we really want to use that global, though? Is that a best practice? In the past I used something like spark = SparkSession.builder.getOrCreate()

@lennartkats-db
Avoid a warning in covid_trends_job.py
9b7fe54 
Using a PEP 484 "# type: ignore" annotation
@fjakobs
Copy link
Collaborator

fjakobs commented Oct 28, 2022

I would rather replace this line with

spark = SparkSession.builder.getOrCreate() since this is the refactored code that should follow best practices.

@fjakobs
Copy link
Collaborator

fjakobs commented Oct 31, 2022

#9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lennartkats-db @fjakobs