Fix Update method of databricks_user (#2878)

The `Update` method wasn't reading the correct set of attributes when updating
user (i.e. when having `force = true`) - this lead that groups were reset to empty state,
and users were losing their groups association.

This fixes #2648

scim/resource_user.go

@@ -110,7 +110,7 @@ func ResourceUser() *schema.Resource {
 			if err != nil {
 				return err
 			}
-			return NewUsersAPI(ctx, c).Update(d.Id(), "userName,displayName,active,externalId,entitlements", u)
+			return NewUsersAPI(ctx, c).Update(d.Id(), u)
 		},
 		Delete: func(ctx context.Context, d *schema.ResourceData, c *common.DatabricksClient) error {
 			user := NewUsersAPI(ctx, c)
@@ -181,5 +181,5 @@ func createForceOverridesManuallyAddedUser(err error, d *schema.ResourceData, us
 	}
 	user := userList[0]
 	d.SetId(user.ID)
-	return usersAPI.Update(d.Id(), "userName,displayName,active,externalId,entitlements", u)
+	return usersAPI.Update(d.Id(), u)
 }

scim/resource_user_test.go

@@ -272,7 +272,7 @@ func TestResourceUserUpdate(t *testing.T) {
 		Fixtures: []qa.HTTPFixture{
 			{
 				Method:   "GET",
-				Resource: "/api/2.0/preview/scim/v2/Users/abc?attributes=userName,displayName,active,externalId,entitlements",
+				Resource: "/api/2.0/preview/scim/v2/Users/abc?attributes=groups,roles",
 				Response: User{
 					DisplayName: "Example user",
 					Active:      true,
@@ -659,7 +659,7 @@ func TestCreateForceOverwriteFindsAndSetsID(t *testing.T) {
 		},
 		{
 			Method:   "GET",
-			Resource: "/api/2.0/preview/scim/v2/Users/abc?attributes=userName,displayName,active,externalId,entitlements",
+			Resource: "/api/2.0/preview/scim/v2/Users/abc?attributes=groups,roles",
 			Response: User{
 				ID: "abc",
 			},
@@ -701,7 +701,7 @@ func TestCreateForceOverwriteFindsAndSetsAccID(t *testing.T) {
 		},
 		{
 			Method:   "GET",
-			Resource: "/api/2.0/preview/scim/v2/Users/abc?attributes=userName,displayName,active,externalId,entitlements",
+			Resource: "/api/2.0/preview/scim/v2/Users/abc?attributes=groups,roles",
 			Response: User{
 				ID: "abc",
 			},

scim/users.go

@@ -66,8 +66,8 @@ func (a UsersAPI) readByPath(userPath string) (user User, err error) {
 }
 
 // Update replaces user information for given ID
-func (a UsersAPI) Update(userID, attributes string, updateRequest User) error {
-	user, err := a.Read(userID, attributes)
+func (a UsersAPI) Update(userID string, updateRequest User) error {
+	user, err := a.Read(userID, "groups,roles")
 	if err != nil {
 		return err
 	}