37 migrate to create streaming table api from create streaming live table #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…able 2.Added expectations for silver layer as part of new create_streaming_table function params 3.Fixed unit and integrations tests with new config change for silver data quality expectations 4.Modidied demo config for silver transformations data quality expectations
2.Modified demo for silver dqe 3.Corrected dbfs api for file create
2.Added doc for silver data quality expectation json
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #39 +/- ##
==========================================
- Coverage 90.28% 89.90% -0.39%
==========================================
Files 8 8
Lines 803 832 +29
Branches 149 161 +12
==========================================
+ Hits 725 748 +23
- Misses 31 33 +2
- Partials 47 51 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
2.Corrected techsummit demo name
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
nfx
reviewed
Mar 19, 2024
| self.ws.dbfs.mkdirs(runner_conf.dbfs_tmp_path + f"/{self.base_dir}/") | ||
| except Exception as e: | ||
| print(f"Error in creating directory {runner_conf.dbfs_tmp_path + f'/{self.base_dir}/'}") | ||
| print(e) |
There was a problem hiding this comment.
Use logger, not print statements
| @@ -726,7 +734,7 @@ def run(self, runner_conf: DLTMetaRunnerConf): | |||
| print(e) | |||
| finally: | |||
| print("Cleaning up...") | |||
| self.clean_up(runner_conf) | |||
| # self.clean_up(runner_conf) | |||
nfx
approved these changes
Mar 19, 2024
ravi-databricks
deleted the
37-migrate-to-create_streaming_table-api-from-create_streaming_live_table
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
create_streaming_live_tableto latestcreate_streaming_tablecreate_streaming_tableapi takesexpectationsas arguments