You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes if failed when "now + 1 minute" was in tomorrow.
For example:
java.lang.IllegalArgumentException: Invalid time range: the upper bound time (00:00:47.593917390) is before the lower bound (23:59:47.593917390)
Sometimes if failed when two paralle threads modify field `shuffledLocales`.
For example:
```
net.datafaker.integration.FakerRepeatabilityIntegrationTest.shouldCreateUniqueValues -- Time elapsed: 0.890 s <<< ERROR!
java.lang.IndexOutOfBoundsException: Index 69 out of bounds for length 69
at java.base/jdk.internal.util.Preconditions.outOfBounds(Preconditions.java:64)
at java.base/jdk.internal.util.Preconditions.outOfBoundsCheckIndex(Preconditions.java:70)
at java.base/jdk.internal.util.Preconditions.checkIndex(Preconditions.java:266)
at java.base/java.util.Objects.checkIndex(Objects.java:361)
at java.base/java.util.ArrayList.remove(ArrayList.java:504)
at net.datafaker.providers.base.Locality.localeStringWithoutReplacement(Locality.java:174)
at net.datafaker.providers.base.Locality.localeStringWithoutReplacement(Locality.java:156)
```
it's not needed to remove the element from shuffledLocales and resize the underlying array.
It's enough just to keep an index of current element in this list.
Enhanced Locality Feature Adjustment
This update involves a modification in the Locality feature. A new field, shuffledLocaleIndex has been added and changes were made in the localeStringWithoutReplacement method. The benefit of this change is that it allows the localeStringWithoutReplacement method to return the next locale in an orderly sequence, thus offering a predictable and simple iteration over the locales.
Exception Handling for Time Boundaries
The Time feature's between method has been updated to throw an informative exception message when bound measurements are violated, specifically if the upper bound time is set before the lower bound. This improves error reporting and ensures the client has the correct details to address these mismatched time boundaries.
Unit Testing Adjustments
Updates have been made in the TimeTest feature. Changes specifically revolve around the improvement of the testBetweenThenLargerThanNow method to accommodate the new formatted exception message, and amendments to the testBetweenWithMask method. The latter now verifies that the result of the between method aligns with a pre-specified pattern and asserts that the parsed time falls within an acceptable time frame.
Introduction of New Constants
The addition of RE_TIME_BETWEEN, NANOSECONDS_IN_DAY, and NANOSECONDS_IN_MINUTE constants serve to enhance precision within time computations and ensure greater accuracy and consistency across the system.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.