Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removal of deprecated code and renamed the old formats to transformers. #698

Closed
wants to merge 1 commit into from

Conversation

bodiam
Copy link
Contributor

@bodiam bodiam commented Feb 12, 2023

No description provided.

@bodiam
Copy link
Contributor Author

bodiam commented Feb 12, 2023

@snuyanzin I've commented out some code related to testing nested JSON, since it was using the old Format class. What would be the best way to proceed here?

@codecov-commenter
Copy link

Codecov Report

Merging #698 (e5c7f78) into main (ad9f575) will increase coverage by 0.23%.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff              @@
##               main     #698      +/-   ##
============================================
+ Coverage     92.50%   92.74%   +0.23%     
+ Complexity     2603     2562      -41     
============================================
  Files           283      280       -3     
  Lines          5295     5042     -253     
  Branches        568      524      -44     
============================================
- Hits           4898     4676     -222     
+ Misses          251      234      -17     
+ Partials        146      132      -14     
Impacted Files Coverage Δ
...ain/java/net/datafaker/providers/base/Address.java 97.14% <ø> (ø)
...n/java/net/datafaker/providers/base/BaseFaker.java 90.99% <ø> (+3.16%) ⬆️
...ain/java/net/datafaker/providers/base/Disease.java 100.00% <ø> (ø)
...ker/idnumbers/pt/br/IdNumberGeneratorPtBrUtil.java 96.29% <0.00%> (+3.70%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@snuyanzin
Copy link
Collaborator

snuyanzin commented Feb 12, 2023

currently there are some cases supported by deprecated code and not supported by transformers...
So first i would support them and then it could be removed.

e.g. for Json @RVRhub submitted #693
so then need also support for xml

now with #699 json could be removed

@bodiam
Copy link
Contributor Author

bodiam commented Feb 12, 2023

currently there are some cases supported by deprecated code and not supported by transformers... So first i would support them and then it could be removed.

e.g. for Json @RVRhub submitted #693 so then need also support for xml

now with #699 json could be removed

oki, in that case, I'll redo this PR, but won't touch the transformation classes.

@bodiam bodiam closed this Feb 12, 2023
@bodiam bodiam deleted the remove_deprecated_code branch March 15, 2023 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants