Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport-1.x] Support list of objects for JSON #826

Merged
merged 1 commit into from
May 7, 2023

Conversation

snuyanzin
Copy link
Collaborator

@snuyanzin snuyanzin commented May 7, 2023

This a backport of #693 to 1.x
just a cherry pick + adapt to jdk8

@codecov-commenter
Copy link

Codecov Report

Merging #826 (f984fa2) into 1.x (b840846) will decrease coverage by 0.29%.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff              @@
##                1.x     #826      +/-   ##
============================================
- Coverage     92.14%   91.85%   -0.29%     
- Complexity     2664     2676      +12     
============================================
  Files           286      287       +1     
  Lines          5487     5540      +53     
  Branches        606      605       -1     
============================================
+ Hits           5056     5089      +33     
- Misses          274      292      +18     
- Partials        157      159       +2     
Impacted Files Coverage Δ
...net/datafaker/transformations/JsonTransformer.java 94.91% <100.00%> (+0.17%) ⬆️

... and 6 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

* Add support list of objects in json transformer

* Add support list of objects in json transformer
@snuyanzin snuyanzin merged commit 8ad4e56 into datafaker-net:1.x May 7, 2023
13 checks passed
@hetzijzo
Copy link

hetzijzo commented May 8, 2023

snuyanzin thanks

@AndyDaSilva52
Copy link

Did the dependency on Maven get updated?

@snuyanzin
Copy link
Collaborator Author

snapshot version is available
1.x release was not done yet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants