update datafusion to 42 #44
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidhewitt
commented
Sep 16, 2024
Comment on lines
+947
to
+952
| // #[tokio::test] | ||
| // async fn test_lexical_precedence_wrong() { | ||
| // let sql = r#"select '{"a": "b"}'->>'a'='b' as v"#; | ||
| // let err = run_query(sql).await.unwrap_err(); | ||
| // assert_eq!(err.to_string(), "Error during planning: Unexpected argument type to 'json_as_text' at position 2, expected string or int, got Boolean.") | ||
| // } |
There was a problem hiding this comment.
@samuelcolvin I assume this test was documenting broken parse precedence and we can now just remove it?
There was a problem hiding this comment.
(Or update it to test the successful case?)
davidhewitt
force-pushed
the
dh/df-42
branch
from
4c7193f
to
b658e61
Compare
|
Datafusion already release 42 |
Merged
|
superceded by #47, it was easier to create a new PR due to conflicts. We can close this once we're no longer using a sha from this branch in logfire. |
davidhewitt
force-pushed
the
dh/df-42
branch
from
b658e61
to
aa2fe69
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Waiting on datafusion 42 release (any day now).