Alternative dev monday #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicogelders
reviewed
Oct 2, 2023
|
|
||
| @flow(**all_flow_kwargs) | ||
| def run_dbt_flow(): #Why not inside of the flow? | ||
| dbt_config=DbtConfig( |
There was a problem hiding this comment.
this should be passed by the user of the lib to the dbt_flow func
nicogelders
reviewed
Oct 2, 2023
prefect_dbt_flow_2/utils/tasks.py
Outdated
| from typing import List, Dict, Optional | ||
|
|
||
| from prefect import task | ||
| from prefect_dbt.cli.commands import trigger_dbt_cli_command |
There was a problem hiding this comment.
i'd rather not depend on prefect_dbt for now
nicogelders
reviewed
Oct 3, 2023
prefect_dbt_flow_2/utils/tasks.py
Outdated
| name=dbt_node.name, | ||
| # retries="", #Do we need this? it goes in dbt_config of prefect config? | ||
| # retry_delay_seconds="", | ||
| ).submint( |
There was a problem hiding this comment.
what does submint do?
Why are you passing the _task_dbt_run to another task? Don't see how this would work?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
I have made changes to the way we configure dbt tasks and the project structure.
Project Structure:
prefect_dbt_flow_2flow.py(entry point)utils__init__.py(contains classes)flow.py(creates the Prefect flow)tasks.py(handles node execution)graph.py(parses nodes from dbt)cmd.py(runs commands)