Skip to content
This repository has been archived by the owner on Jun 6, 2024. It is now read-only.

feat: print files that skipped k8s validation #589

Merged
merged 13 commits into from
Apr 28, 2022
Prev Previous commit
Next Next commit
refactor: add a check in validateResource for isValid before adding t…
…he skip warning, this doesn't effect performance but is more correct
  • Loading branch information
royhadad committed Apr 28, 2022
commit 7def0d981090b916dd3fa0b1422f140da68521a9
2 changes: 1 addition & 1 deletion bl/validation/k8sValidator.go
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,7 @@ func (val *K8sValidator) validateResource(filepath string) (bool, []error, *vali
}
}
var warning *validationWarning = nil
if isAtLeastOneConfigSkipped {
if isAtLeastOneConfigSkipped && isValid {
warning = &validationWarning{
WarningKind: Skipped,
WarningMessage: "I skipped k8s cause missing resource definition",
Expand Down