Skip to content
This repository has been archived by the owner on Jun 6, 2024. It is now read-only.

fix(ci): adjust PR titles check #695

Merged
merged 8 commits into from
Jun 27, 2022
Merged

fix(ci): adjust PR titles check #695

merged 8 commits into from
Jun 27, 2022

Conversation

naorpeled
Copy link
Contributor

@naorpeled naorpeled commented Jun 24, 2022 •
edited
Loading

Scopes are a part of the conventional commits spec.
As seen in here.

changes:

  • allow scopes in PR titles
  • added breaking changes support (e.g. chore!: drop support for Node 6)

@naorpeled naorpeled changed the title fix(ci): allow scopes in PR titles feat(ci): allow scopes in PR titles Jun 24, 2022
@naorpeled naorpeled marked this pull request as ready for review June 24, 2022 00:11
@naorpeled naorpeled changed the title feat(ci): allow scopes in PR titles feat: allow scopes in PR titles Jun 24, 2022
@naorpeled naorpeled changed the title feat: allow scopes in PR titles feat allow scopes in PR titles Jun 24, 2022
@naorpeled naorpeled changed the title feat allow scopes in PR titles feat allow scopes in PR titles 2 Jun 24, 2022
@naorpeled naorpeled changed the title feat allow scopes in PR titles 2 build: allow scopes in PR titles 2 Jun 24, 2022
@naorpeled naorpeled changed the title build: allow scopes in PR titles 2 build(scope): allow scopes in PR titles 2 Jun 24, 2022
@naorpeled naorpeled changed the title build(scope): allow scopes in PR titles 2 feat(ci): allow scopes in PR titles Jun 24, 2022
@naorpeled naorpeled changed the title feat(ci): allow scopes in PR titles feat(ci): adjust PR titles check Jun 24, 2022
@naorpeled naorpeled changed the title feat(ci): adjust PR titles check feat!(ci): adjust PR titles check Jun 24, 2022
@naorpeled naorpeled changed the title feat!(ci): adjust PR titles check feat(ci)!: adjust PR titles check Jun 24, 2022
@naorpeled naorpeled changed the title feat(ci)!: adjust PR titles check !feat(ci): adjust PR titles check Jun 24, 2022
@naorpeled naorpeled changed the title !feat(ci): adjust PR titles check feat(ci): adjust PR titles check Jun 24, 2022
@myishay
Copy link
Contributor

myishay commented Jun 27, 2022

LGTM!
I updated your branch with the latest changes and will merge it once it passed the tests

@myishay myishay merged commit 662747b into datreeio:main Jun 27, 2022
@myishay myishay changed the title feat(ci): adjust PR titles check fix(ci): adjust PR titles check Jun 27, 2022
@naorpeled naorpeled deleted the fix/ci/add-scope-to-pr-title-check branch June 27, 2022 21:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@myishay myishay myishay approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@naorpeled @myishay