only call find if there is a diff

davebx · Jan 5, 2022 · d31ed3a · d31ed3a
1 parent 6176643
commit d31ed3a
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/.github/workflows/pr.yaml b/.github/workflows/pr.yaml
@@ -230,7 +230,11 @@ jobs:
         fetch-depth: 0
     - name: Check file sizes
       run: |
-        find $(git diff --diff-filter A --name-only ${{ needs.setup.outputs.commit-range }}) -type f -size +${{ env.MAX_FILE_SIZE }} > file_size_report.txt
+        touch file_size_report.txt
+        GITDIFF=$(git diff --diff-filter A --name-only ${{ needs.setup.outputs.commit-range }})
+        if [ -n "$GITDIFF" ]; then
+          find "$GITDIFF" -type f -size +${{ env.MAX_FILE_SIZE }} > file_size_report.txt
+        fi
         if [[ -s file_size_report.txt ]]; then
           echo "Files larger than ${{ env.MAX_FILE_SIZE }} found"
           cat file_size_report.txt