adding tls client certificate support #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pected is pem with private key and cert in same pem file
theckman
suggested changes
Sep 29, 2016
| @@ -63,6 +64,8 @@ var ( | |||
| redirectsFollowed int | |||
|
|
|||
| version = "devel" // for -v flag, updated during the release process with -ldflags=-X=main.version=... | |||
|
|
|||
| clientCertFile string | |||
There was a problem hiding this comment.
Can this be moved up to be with the rest of the command line flags?
There was a problem hiding this comment.
Agree, will change.
| @@ -77,6 +80,7 @@ func init() { | |||
| flag.BoolVar(&saveOutput, "O", false, "Save body as remote filename") | |||
| flag.StringVar(&outputFile, "o", "", "output file for body") | |||
| flag.BoolVar(&showVersion, "v", false, "print version number") | |||
| flag.StringVar(&clientCertFile, "c", "", "client cert file for tls config") | |||
There was a problem hiding this comment.
What do you think about using E, which is the same flag cURL uses? This project is a Go version of httpstat.py, which is just a wrapper around cURL. So we should try to keep as much parity as possible in my opinion.
There was a problem hiding this comment.
Agree, will change.
…aration to be with others
theckman
approved these changes
Sep 29, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #94
This pull request adds support for client certificates. To use specify a client certificate in PEM format that includes both the certificate and the private key in the same file with the "-c" flag.