Skip to content

Commit

Permalink
[IMP] web: rename cancel button in RedirectWarning to close
Browse files Browse the repository at this point in the history
"Cancel" button in the RedirectWarning is renamed to "Close"

task-3339621

closes odoo#125751

Signed-off-by: Quentin De Paoli <qdp@odoo.com>
  • Loading branch information
alialfie committed Jul 3, 2023
1 parent 7694f01 commit 3c6c6e6
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion addons/web/static/src/core/errors/error_dialogs.xml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
</div>
<t t-set-slot="footer">
<button class="btn btn-primary" t-on-click="onClick" t-esc="buttonText"/>
<button class="btn btn-secondary" t-on-click="props.close">Cancel</button>
<button class="btn btn-secondary" t-on-click="props.close">Close</button>
</t>
</Dialog>
</t>
Expand Down
2 changes: 1 addition & 1 deletion addons/web/static/tests/core/errors/error_dialogs_tests.js
Original file line number Diff line number Diff line change
Expand Up @@ -233,7 +233,7 @@ QUnit.test("RedirectWarningDialog", async (assert) => {
const footerButtons = target.querySelectorAll("footer button");
assert.deepEqual(
[...footerButtons].map((el) => el.textContent),
["Buy book on cryptography", "Cancel"]
["Buy book on cryptography", "Close"]
);
await click(footerButtons[0]); // click on "Buy book on cryptography"
assert.verifySteps(["buy_action_id", "dialog-closed"]);
Expand Down

0 comments on commit 3c6c6e6

Please sign in to comment.