Enhance defcustom definitions #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While there is a `list' type in `defcustom', it is meant for a very specific list. '(list string) means that you want a list with exactly one string. '(list string function) means that the customizable variable should take two elements: a string and a function. However, we want arbitrary many strings, that's what `repeat' is for. Note that we could probably use `file' instead of `string', but the auto-completion does not recognize the `dotfiles-folder' as search-folder. Oh well. For directories there is the special type 'directory'.
|
Hi @daviwil, how can I improve this PR to get it merged? Thanks :) |
|
No improvements needed, thanks for pointing this out! I wish I had got these details right in the video |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While there is a
list'type indefcustom, it is meant for a very specific list.'(list string)means that you want a list with exactly one string.'(list string function)means that the customizable variable should take two elements: a string and a function.However, we want arbitrary many strings, that's what
repeatis for, e.g.Note that we could probably use
fileinstead ofstringindotfiles-org-files, but I don't know how to make customize's auto-completion recognize thedotfiles-folderas search-folder. To enable auto-completion on the latter, we can use the:type'directory.