Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Windows] Unable to create workspace for repos containing .devcontainer #736

Closed
anuragkainth opened this issue Jul 8, 2024 · 13 comments
Closed
Labels
💎 Bounty bug Something isn't working help wanted Extra attention is needed never stale An issue that never goes stale

Comments

@anuragkainth
Copy link

anuragkainth commented Jul 8, 2024

Describe the bug
On creation of Daytona workspace for repos containing .devcontainer, giving: "failed to create workspace: container exited with status 2"

To Reproduce
Steps to reproduce the behavior:

  1. Create a workspace using daytona create command.
  2. Enter repo containing .devcontainer, example: https://github.com/daytonaio/daytona
  3. See error

Screenshots
image

Desktop (please complete the following information):

  • OS: Windows 11
  • Daytona Version: 0.21.1

Additional context
Workspace getting created successfully for repos not having .devcontainer file.

@anuragkainth anuragkainth added the bug Something isn't working label Jul 8, 2024
@idagelic idagelic assigned idagelic and unassigned idagelic Jul 8, 2024
@idagelic idagelic added the backlog backlog until further notice label Jul 15, 2024
@idagelic idagelic changed the title Unable to create workspace for repos containing .devcontainer [Windows] Unable to create workspace for repos containing .devcontainer Jul 15, 2024
@lbrecic lbrecic removed the backlog backlog until further notice label Jul 17, 2024
@lbrecic
Copy link
Contributor

lbrecic commented Jul 17, 2024

/bounty $30

Copy link

algora-pbc bot commented Jul 17, 2024

💎 $60 bounty • Daytona

Steps to solve:

  1. Start working: Comment /attempt #736 with your implementation plan
  2. Submit work: Create a pull request including /claim #736 in the PR body to claim the bounty
  3. Receive payment: 100% of the bounty is received 2-5 days post-reward. Make sure you are eligible for payouts

If no one is assigned to the issue, feel free to tackle it, without confirmation from us, after registering your attempt. In the event that multiple PRs are made from different people, we will generally accept those with the cleanest code.

Please respect others by working on PRs that you are allowed to submit attempts to.

e.g. If you reached the limit of active attempts, please wait for the ability to do so before submitting a new PR.

If you can not submit an attempt, you will not receive your payout.

Thank you for contributing to daytonaio/daytona!

Add a bountyShare on socials

Attempt Started (GMT+0) Solution
🔴 @bryans-go Sep 13, 2024, 8:11:02 AM WIP

@RS-labhub
Copy link
Contributor

This is working fine for me on Ubuntu and Linux (used codespaces and gitpod). I'm not able to run it locally on my windows due to insufficient space. Though I guess removing the devcontainer flags from the https://github.com/daytonaio/daytona/blob/main/pkg/cmd/workspace/create.go will work! If you allow me, I can open a PR, but w/o testing. 🙂

@idagelic
Copy link
Member

@RS-labhub Not sure I understood you correctly, are you proposing solving this by not using a devcontainer at all? That is not a viable option, also opening a PR without making sure it works by testing cannot be accepted

@RS-labhub
Copy link
Contributor

@RS-labhub Not sure I understood you correctly, are you proposing solving this by not using a devcontainer at all? That is not a viable option, also opening a PR without making sure it works by testing cannot be accepted

That's what the problem. My PC doesn't have space, even if I clean it thoroughly, it won't fulfil the min. requirements.

btw I thought, you guys are on holiday as it's a weekend 🙂

@Tpuljak Tpuljak added the never stale An issue that never goes stale label Jul 30, 2024
@lbrecic lbrecic added the help wanted Extra attention is needed label Aug 29, 2024
@Pious1020
Copy link

Hey @RS-labhub, could you assign me to this issue

@RS-labhub
Copy link
Contributor

@Pious1020 I'm also a contributor and not a maintainer... By the way, you don't need to ask for this. You can work on it directly and submit a PR.

@bryans-go
Copy link
Contributor

bryans-go commented Sep 13, 2024

/attempt #736

Algora profile Completed bounties Tech Active attempts Options
@bryans-go 2 daytonaio bounties
Cancel attempt

@bryans-go
Copy link
Contributor

@Tpuljak
Windows dtn_create_with_devcontainer_json_Success
We can clearly see that the issue is resolved or not reproducing in the latest version of the daytona (0.30.1) I was suceesful in creating https://github.com/daytonaio/sample-typescript-node (also it has .devcontainer) using daytona create . I think @anuragkainth got error because of some bugs in docker desktop for windows at that time

@Tpuljak
Copy link
Member

Tpuljak commented Sep 13, 2024

@bryans-go thanks for that!

@anuragkainth can we get a confirmation from your side that the issue is resolved in the latest version of Daytona?

@bryans-go
Copy link
Contributor

bryans-go commented Sep 13, 2024

Screenshot (10)
daytona also works

@Tpuljak
Copy link
Member

Tpuljak commented Sep 23, 2024

Closing this. @anuragkainth let us know if the issue still persists.

@Tpuljak Tpuljak closed this as completed Sep 23, 2024
@anuragkainth
Copy link
Author

@Tpuljak, apologies for the late response. I tried daytona and starter-mern-saas repos (both having devcontainers) using Daytona v0.35.0 on windows and issue seems resolved now.

image
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💎 Bounty bug Something isn't working help wanted Extra attention is needed never stale An issue that never goes stale
Projects
None yet
Development

No branches or pull requests

7 participants