Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug fix: sudo dockerd removed #717

Merged
merged 1 commit into from
Jul 4, 2024
Merged

Conversation

RS-labhub
Copy link
Contributor

Pull Request Title

bug fix: sudo dockerd removed

Description

Atm. sudo dockerd is the default post-start command. This is no longer needed and should be removed.

  • This change requires a documentation update
  • I have made corresponding changes to the documentation

Related Issue(s)

Closes #716

@RS-labhub RS-labhub requested a review from a team as a code owner June 28, 2024 17:33
@RS-labhub RS-labhub force-pushed the dockerd_bug branch 2 times, most recently from ca1eacd to 94a9552 Compare June 28, 2024 17:37
Copy link
Member

@Tpuljak Tpuljak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RS-labhub please run git commit --allow-empty -s -m "Empty-Commit" and push to this branch. This should re-trigger the PR checks. There seems to have been an issue with Github that prevented them from running when you opened the PR.

Signed-off-by: Rohan Sharma <rohansharma9386262846@gmail.com>
@RS-labhub
Copy link
Contributor Author

@RS-labhub please run git commit --allow-empty -s -m "Empty-Commit" and push to this branch. This should re-trigger the PR checks. There seems to have been an issue with Github that prevented them from running when you opened the PR.

Thanks... All checks have passed now. 🥹

Copy link
Member

@Tpuljak Tpuljak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@idagelic idagelic merged commit 4c2431b into daytonaio:main Jul 4, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove dockerd from default post start command
3 participants