fix: remove presence of leftover data from previous page in TUI (#592)

[abhishek818]

fix: remove presence of leftover data from previous page in TUI (#592)
fix: filter input gets duplicated in full screen tui (#668)

1. consider height of other ui components ('title' header in this case) while setting window height for workspaces list.
2. set a max height for workspace selection view.

• This change requires a documentation update
• I have made corresponding changes to the documentation

This PR addresses issue #592 and #668

closes #592
closes #668

/claim #592

[abhishek818]

@idagelic @Tpuljak Up for review.

[abhishek818]

i demand additional tip for the level of stupid ways i tried to solve this.. :p 😅

[abhishek818]

PS: subtracting height by 4 is more safer (due to title header + 'current profile' line tag at end of tui), just check it out once on your screens, using 3 just worked for me.

Also one of other tried ways:

// fails
case tea.WindowSizeMsg:
      h, v := views.DocStyle.GetFrameSize()
      itemHeight := lipgloss.NewStyle().GetVerticalFrameSize() + 4
      availableHeight := msg.Height - v
      
      itemsPerPage := availableHeight / itemHeight
      remainingItems := len(m.list.Items()) % itemsPerPage
      
      if remainingItems > 0 {
	      m.list.SetSize(msg.Width-h, remainingItems*itemHeight+v)
      }

[idagelic]

Hi @abhishek818, thanks for the PR

As you can see on this closed PR, there was a similar attempt with changing the height of the view which resulted in big empty bars on the top and bottom of the view. We were hoping for a solution that doesn't make this compromise and fixes the underlying issue instead which is why we kept the issue open. Please let me know if you find a solution that gets rid of the residue without sacrificing the space

Here are the screenshot from your branch and main

[abhishek818]

@idagelic hey I have pushed 1 more commit related to this issue.

My fixes results in listing of 11 repo results instead of 12. I have found several other repos like this where they are hardcoding a value to be sub/add to the height/widths. Overall, all these ui issues are related to allotment of appropriate heights/widths for respective ui components. I find this is the only way to fix this.

Refer some discussions on bubbletea repos: here1 and here2

Also, I think the tradeoff of some empty space for these fixes is a better deal.
Anyways upto you.. 😅 just trying to convince you.

BEFORE:

AFTER:

[abhishek818]

PS: had tried fixing empty spaces at header and footer by changing padding etc. Nothing works once height is manipulated for workspaces list in the view file..
CC: @idagelic

[abhishek818]

@idagelic you got time to review ?
your views on above comments #725 (comment) ?

[idagelic]

@abhishek818 The difference is less obvious on full screen terminal windows, but when there would only be 3 elements in the list page, that number is now reduced to 2 for example. Also, you unintentionally "lost" the "Active profile" footer under the view.
I agree that the last page residue is still an issue and I would love to have it resolved - I'll request an opinion from another maintainer.

[Tpuljak]

@abhishek818 The difference is less obvious on full screen terminal windows, but when there would only be 3 elements in the list page, that number is now reduced to 2 for example. Also, you unintentionally "lost" the "Active profile" footer under the view.

I believe too much space was lost here. It would've been fine if maybe only one row was lost. Is that a possibility @abhishek818?

Also, losing the active profile footer label is not an option. It needs to be shown in all the places as before.

[abhishek818]

Also, you unintentionally "lost" the "Active profile" footer under the view.

fixed, brought it back.

I believe too much space was lost here. It would've been fine if maybe only one row was lost. Is that a possibility @abhishek818?

yeah, unfortunately cant resolve the empty height issue. This is weird, have tried resizing to terminal's height everywhere but once list's size is fixed here nothing can be done.

Ultimately, this fix solves both the last page residue and filter input getting duplicated issues. Upto you guys.
@Tpuljak @idagelic

[Tpuljak]

	if m.list.FilterState() == list.Filtering {
		return views.DocStyle.MaxWidth(terminalWidth - 4).Height(terminalHeight - 4).Render(m.list.View() + m.footer)
	}

	return views.DocStyle.MaxWidth(terminalWidth - 4).Height(terminalHeight - 2).Render(m.list.View() + m.footer)

I believe this solution works best. It minimizes space lost at the top (it remains at 2 empty rows which is what we want) and doesn't cause "ghosted items" when filtering.

[abhishek818]

	if m.list.FilterState() == list.Filtering {
		return views.DocStyle.MaxWidth(terminalWidth - 4).Height(terminalHeight - 4).Render(m.list.View() + m.footer)
	}

	return views.DocStyle.MaxWidth(terminalWidth - 4).Height(terminalHeight - 2).Render(m.list.View() + m.footer)

I believe this solution works best. It minimizes space lost at the top (it remains at 2 empty rows which is what we want) and doesn't cause "ghosted items" when filtering.

yes, works best, thanks. (now only leaves out a single trace only when the list size is 2 items but thats okay..)

Only 2 small issues with filter mode left :

1. type something in input, then erase it to type some other query, filter input gets duplicated.
2. leaves traces of search results while typing the search query and after the final results.

Just replacing with 'MaxHeight' below resolves it.

if m.list.FilterState() == list.Filtering {
		return views.DocStyle.MaxWidth(terminalWidth - 4).Height(terminalHeight - 4).Render(m.list.View() + m.footer)
	}

@Tpuljak

[Tpuljak]

Seems to work great now. Thanks!

[idagelic]

This works well now.
I see that you put this PR closes #668 as well - yes, it fixes the filter issue which is great. Have you had any success reproducing and fixing the problem when the cursor sometimes moves to the bottom of the screen making it impossible to select items?

[abhishek818]

This works well now. I see that you put this PR closes #668 as well - yes, it fixes the filter issue which is great. Have you had any success reproducing and fixing the problem when the cursor sometimes moves to the bottom of the screen making it impossible to select items?

Perhaps pressing any key or '/' during the loading time (i.e. when it is about to render the next view) is the way to reproduce this. Not sure about it and not sure if this can even be resolved..

Will checkout this issue some other day.

[abhishek818]

bounty not credited yet, Is it delayed on algora's side? @Tpuljak

[Tpuljak]

@abhishek818 my bad on that one. I configured auto-payouts shortly after abut this one didn't go through so I processed it manually now.