Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dbt-semantic-interfaces dependency to compatible range #9671

Merged
merged 1 commit into from
Feb 26, 2024

Conversation

tlento
Copy link
Contributor

@tlento tlento commented Feb 26, 2024

A recent update to the version ranges for our internally
maintained support packages quite reasonably expanded the
allowed versions for dbt-semantic-interfaces to all minor versions
after 0.5.0, under the assumption that subsequent releases will
generally be backwards-compatible.

Unfortunately, dbt-semantic-interfaces is not yet in that state.
So we update the version range accordingly, and include some
comments around version range expectations for dependencies
listed in this section of dbt-core's package configuration.

@cla-bot cla-bot bot added the cla:yes label Feb 26, 2024
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@tlento tlento changed the title fix dsi version range Update dbt-semantic-interfaces dependency to compatible range Feb 26, 2024
Copy link

codecov bot commented Feb 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.02%. Comparing base (4b6c57c) to head (887d30d).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9671      +/-   ##
==========================================
+ Coverage   87.99%   88.02%   +0.03%     
==========================================
  Files         177      177              
  Lines       22350    22356       +6     
==========================================
+ Hits        19667    19679      +12     
+ Misses       2683     2677       -6     
Flag Coverage Δ
integration 85.47% <ø> (+0.03%) ⬆️
unit 62.13% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

A recent update to the version ranges for our internally
maintained support packages quite reasonably expanded the
allowed versions for dbt-semantic-interfaces to all minor versions
after 0.5.0, under the assumption that subsequent releases will
generally be backwards-compatible.

Unfortunately, dbt-semantic-interfaces is not yet in that state.
So we update the version range accordingly, and include some
comments around version range expectations for dependencies
listed in this section of dbt-core's package configuration.
@tlento tlento marked this pull request as ready for review February 26, 2024 20:35
@tlento tlento requested a review from a team as a code owner February 26, 2024 20:35
@QMalcolm QMalcolm merged commit d50aebb into main Feb 26, 2024
58 checks passed
@QMalcolm QMalcolm deleted the fix-dsi-version-range branch February 26, 2024 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants