Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add browserify-friendly field to package.json #1005

Closed
dgerber opened this issue Sep 11, 2015 · 1 comment
Closed

Add browserify-friendly field to package.json #1005

dgerber opened this issue Sep 11, 2015 · 1 comment
Labels
enhancement
Milestone
non-breaking

Comments

@dgerber
Copy link

dgerber commented Sep 11, 2015

Adding a field browser: "dc.js" to package.json will tell browserify not to try including jsdom in the bundle, nor tamper with globals. It's done this way in d3.js and works well.
@gordonwoodhull
Copy link
Contributor

Thanks @dgerber, I rely on help from the community on the browserify support, since I don't use it myself (yet!)

@gordonwoodhull gordonwoodhull added this to the v2.0 milestone Oct 6, 2015
@sdunster sdunster mentioned this issue Dec 10, 2015
Merged
sdunster added a commit to sdunster/dc.js that referenced this issue Dec 10, 2015
@sdunster
Add browser: dc.js to package.json for Browserify
e2a53ad 
This will make Browserify skip bundling the scripts intended to run on
CommonJS platforms and instead make it bundle dc.js directly. This fixes
problems where Browserify is unable to find jsdom because it is not listed
in the dependencies (and is not required on browser anyway). Resolves dc-js#1005.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
non-breaking
Development

No branches or pull requests
2 participants
@dgerber @gordonwoodhull