Clip path code broken in latest master

[bigianb]

Since updating to master, I see the following error when displaying a chart:
Failed to execute query: '#1-clip' is not a valid selector.
I'm pretty sure this is due to pr #733

Digging a bit more, the issue is that the default anchor name starts with a number ... and DOM ids must start with a letter. Making the change below (i.e. changing '' in the last line to 'id') fixes the issue as the id now starts with a letter.

_chart.anchorName = function () {
        var a = _chart.anchor();
        if (a && a.id) {
            return a.id;
        }
        if (a && a.replace) {
            return a.replace('#', '');
        }
        return 'id' + _chart.chartID();
    };

[gordonwoodhull]

Thanks @bigianb. This may also be related to #685, or more likely the bug was already there but was masked by the bug #733 fixes, as the number id behavior has been there for some time.

[bigianb]

Yes, I agree.

[r4j4h]

I don't know if this is actually the fix you would like to see @gordonwoodhull , but I put in bigian's change in a PR as master is definitely broken for me without this so perhaps we should merge it in at least in the interim to a better solution?

[r4j4h]

Just updating this issue ticket that my PR is now good to go. :) 👍

[Frozenlock]

Just wanted to chime in: I get the same error when trying any version after early December.

Without being familiar with the code, I tried to pinpoint the origin:
da2d4ee#commitcomment-9174465

[gordonwoodhull]

fixed by #800