Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

weird enter & exit transitions for bar chart #822

Open
gordonwoodhull opened this issue Dec 31, 2014 · 1 comment
Open

weird enter & exit transitions for bar chart #822

gordonwoodhull opened this issue Dec 31, 2014 · 1 comment
Labels
bug transition
Milestone
breaking

Comments

@gordonwoodhull
Copy link
Contributor

bar enter-exit transitions

Once again, the enter transition should start where the bar would be in the before-scale, and the exit transition should end where the bar would end in the after-scale.

In addition, the bars are collapsing from the bottom up when they should collapse from the top down. (Although that might not matter, and might be a bad idea, if they are leaving to the left or right - maybe more accurate to just let them leave the screen.)

Can be seen in multi-focus example:

http://dc-js.github.io/dc.js/examples/multi-focus.html
@gordonwoodhull gordonwoodhull added this to the v2.1 milestone Dec 31, 2014
@gordonwoodhull gordonwoodhull modified the milestones: v2.0, v2.1 May 24, 2015
Fil added a commit to Fil/dc.js that referenced this issue May 20, 2016
@Fil
fix weird transition on barChart exit() dc-js#822
96532c0 
the transition to `height(0)` was making the bar "fly away", now we keep its y and height, but transition it towards where it "should be". trimming a little bit of the width gives nicer results imho so that a small ap is preserved between bars. But it's something that can be removed if you prefer to keep it simple.
Fil added a commit to Fil/dc.js that referenced this issue May 21, 2016
@Fil
fix weird transition on barChart exit() dc-js#822 (see also dc-js#1145)
590a075
@gordonwoodhull
Copy link
Contributor Author

The exit transitions are improved in #1146 / 2.0 beta 32. The enter transitions still need to be fixed, but that means keeping around the previous scale, which is a bigger change.

gordonwoodhull pushed a commit that referenced this issue Jul 27, 2016
@Fil @gordonwoodhull
fix weird transition on barChart exit() #822 (see also #1145)
b8b8111
gordonwoodhull pushed a commit that referenced this issue Jul 28, 2016
@Fil @gordonwoodhull
fix weird transition on barChart exit() #822 (see also #1145)
8c81b2d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug transition
Projects
None yet
Milestone
breaking
Development

No branches or pull requests
1 participant
@gordonwoodhull