Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exposes emptyOpacity, emptyColor for scatterplot #1058

Closed
wants to merge 2 commits into from

Conversation

lastlegion
Copy link
Contributor

For greying out hidden points instead of hiding them. Useful for doing SPLOMs like this one:
http://bl.ocks.org/mbostock/4063663

@gordonwoodhull gordonwoodhull added this to the v2.0 milestone Feb 9, 2016
@gordonwoodhull
Copy link
Contributor

Hmm, good idea. Thanks for contributing, @lastlegion.

@gordonwoodhull gordonwoodhull changed the title exposes hiddenOpacity, hiddenColor for scatterplot exposes emptyOpacity, emptyColor for scatterplot Dec 20, 2016
@gordonwoodhull
Copy link
Contributor

gordonwoodhull commented Dec 20, 2016

Thanks @lastlegion!

In the meantime (5dc00e1 for #938 ) I had already exposed hiddenSize and renamed it emptySize because I think that's more descriptive - so the new one is hiddenOpacity.

Also it looks like you never implemented hiddenColor so I implemented emptyColor.

Released in 2.0

gordonwoodhull added a commit that referenced this pull request Dec 20, 2016
s/hidden/empty/g
for #1058 and cleanup
gordonwoodhull added a commit that referenced this pull request Dec 20, 2016
gordonwoodhull added a commit that referenced this pull request Dec 20, 2016
gordonwoodhull added a commit that referenced this pull request Dec 20, 2016
for #1058
now to format it better
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants