Separate groups for pie chart slices and labels #1167
Conversation
|
+1 |
|
Great, thanks @maackle! |
|
👍 |
|
Hmm, the |
|
I think the pointer-events thing is tangential to the issue at hand anyway. I have such a thing in my own CSS but it's a pretty easy DIY whereas the slice layering isn't. |
|
You're right, I'll remove that commit |
|
I've already merged this to my working branch with a replacement (highlighting the slice when the corresponding label or path is hovered - the commit is referenced above). But I ran into problems writing the tests so it's not released yet. |
for #1167 but wow! the test dynamically fails to compile due to dc.transition returning a selection if duration===0
for #1167 apparently this is the only place where our use of dc.selection is risky, because we don't use the *tween functions very much places where this problem is currently avoided: - lineChart has .ease commented-out - numberDisplay does not use dc.transition
for #1167 but wow! the test dynamically fails to compile due to dc.transition returning a selection if duration===0
for #1167 apparently this is the only place where our use of dc.selection is risky, because we don't use the *tween functions very much places where this problem is currently avoided: - lineChart has .ease commented-out - numberDisplay does not use dc.transition
|
Rebased and merged in 2.0 beta 32, along with handlers highlighting the slice when a label or path is hovered. Thanks @maackle! |
Adds another layer of
g, one for each of slices and labels, to ensure the latter always appear after the former in the DOMFixes #664