Fixed numberDisplay tweening getting stuck on Infinity values #1177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@XaserAcheron, I'm adding your example under transitions/ so that we have a visual test (along with a Jasmine test). |
gordonwoodhull
added a commit
that referenced
this pull request
Jul 27, 2016
gordonwoodhull
added a commit
that referenced
this pull request
Jul 27, 2016
|
Coolness -- I ought to figure out how to do this myself in the future to save you the trouble. On that note, I'm exceptionally glad the Rush example is now canon. ;P |
gordonwoodhull
added a commit
that referenced
this pull request
Jul 28, 2016
gordonwoodhull
added a commit
that referenced
this pull request
Jul 28, 2016
|
Thanks @XaserAcheron, rebased and merged in 2.0 beta 32! I'm also very happy to include the Rush example. It's here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1176. Basically just added
-InfinityandInfinityto the list of values to alias to zero (along with all "falsy" types) for the first parameter of thed3.interpolateNumbercall. Works like a charm.