Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove brush handles for scatter-plot #1407

Merged
merged 1 commit into from
Apr 15, 2018
Merged

Remove brush handles for scatter-plot #1407

merged 1 commit into from
Apr 15, 2018

Conversation

kum-deepak
Copy link
Collaborator

Fixes #1406

@kum-deepak
Copy link
Collaborator Author

Sorry #1402 went too ambitious. I separated out just this bit. Other changes I will submit as a new PR.

@gordonwoodhull
Copy link
Contributor

Definitely not too ambitious!

It's exactly the kind of help I need: looking at the interaction of multiple features over multiple charts, and considering the big picture. And I think your approach is correct.

It's just that I want to get to 3.0 without making any major changes except those related to the D3 port.

Here are the known issues for 3.0: https://github.com/dc-js/dc.js/issues?q=is%3Aopen+is%3Aissue+milestone%3A3.0

(the other milestones are out of date since they were created before d3v4)

Please do take up challenging projects like the composite brushing problem! But wherever possible, keep separate projects in separate branches, and evaluate the risk on each project.

dc.js has had multiple branches of development for a couple of years (using git flow), and I think it really helps. It's not moving quite as fast as it was before I became maintainer, but also not as much stuff is getting broken.

@gordonwoodhull gordonwoodhull merged commit 4ee0146 into dc-js:3.0 Apr 15, 2018
@kum-deepak kum-deepak deleted the incorrect-brush-handles branch April 15, 2018 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants