Fixing fade deselected. Possible fix of #1401

[kum-deepak]

Bit of a coincidence, figured out why bar were turning gray in 3.0 in multi focus example. It also fixes strange fading in http://localhost:8888/web/examples/filter-stacks.html.

In 2.1, fadeDeselectedArea was effecting the fade only if the chart had brush on. I have added these as explicit check now.

See, if this should be accepted as a fix.

[gordonwoodhull]

I never saw the fading problem in filter-stacks until today! All this time I've been wondering what you were talking about.

Finally tested in Safari, and yeah, that's pretty bad. Stuff like this:

Inconsistent, too, sometimes it looked correct:

And yes, it fixes the distracting multi-focus issue as well. Thanks so much for figuring this out!

[gordonwoodhull]

Merged for 3.0 beta 1

[gordonwoodhull]

Rats, this broke ordinal bar selection, eg

http://127.0.0.1:8888/web/examples/ordinal-bar.html

vs

https://dc-js.github.io/dc.js/examples/ordinal-bar.html

And this test case: dc.barChart rendering with an ordinal x domain should fade deselected bars (otherwise I might not have noticed)

@kum-deepak, do you remember any other special cases having to do with isOrdinal?

Almost there! So close.......

[kum-deepak]

I will check later today or tomorrow morning. I had a suspicion that this fix may cause other problems.

…

On April 20, 2018 2:51:04 PM UTC, Gordon Woodhull ***@***.***> wrote: Rats, this broke ordinal bar selection, eg http://127.0.0.1:8888/web/examples/ordinal-bar.html vs https://dc-js.github.io/dc.js/examples/ordinal-bar.html @kum-deepak, do you remember any other special cases having to do with `isOrdinal`? -- You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub: #1422 (comment)

-- Sent from my Android device with K-9 Mail. Please excuse my brevity.

[gordonwoodhull]

Thanks @kum-deepak, I tried moving it to the non-ordinal section of barChart.fadeDeselectedArea and that fixed it. I'll push that fix to 3.0.

However, there are still infinite recursion bugs on range-series. I'll see if #1408 helps with that and file an issue.