Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Sunburst centering on redraw #1491

Closed
wants to merge 2 commits into from
Closed

Fix Sunburst centering on redraw #1491

wants to merge 2 commits into from

Conversation

Frozenlock
Copy link
Contributor

Fixes #1490

@Frozenlock Frozenlock mentioned this pull request Oct 9, 2018
Closed
@gordonwoodhull
Copy link
Contributor

gordonwoodhull commented Oct 9, 2018 •
edited
Loading

I'm confused. Now the sunburst seems to get into the right position but not resize (change radius)?

EDIT: it seems to work if I manually set the radius to falsy during the resize operation. But I guess it needs to have the same _givenRadius clutter that the pie chart has. I guess I'll go ahead and add that, but @Frozenlock, please confirm that you were manually resetting the radius on resize?

@gordonwoodhull
Copy link
Contributor

Thanks @Frozenlock! Merged and released as 3.0.8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Frozenlock @gordonwoodhull