Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forwarding the data object rather than its parent to pieChart's title fu... #824

Merged
merged 1 commit into from
Apr 3, 2015

Conversation

r4j4h
Copy link
Contributor

@r4j4h r4j4h commented Jan 5, 2015

...nction in reference to issue #755

@r4j4h
Copy link
Contributor Author

r4j4h commented Jan 5, 2015

Re-created this branch b/c the old one had a merge in it. This has been rebased on top of latest master.

For reference: The old issue #757 had Bug Label and v2.0 milestone

@gordonwoodhull
Copy link
Contributor

Thanks @r4j4h!

For future reference it is actually okay to rebase a pull request branch and git push -f it. You'll see many maintainers requesting this on Github.

This is because it is highly unlikely that anyone is working on a fork of the same branch, so it is okay if history gets mangled. This seems to be the one exception to the rule.

gordonwoodhull added a commit that referenced this pull request Apr 3, 2015
@gordonwoodhull gordonwoodhull merged commit 92084d6 into dc-js:master Apr 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants