-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding an input filter #936
Conversation
fixes dc-js#926 elasticX not working for series chart
src/filter-input.js
Outdated
return _chart; | ||
}; | ||
|
||
var throttleTimer; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the convention is to put an underscore before private variables, and put them at the top of the "class"
I've rebased this to a branch: https://github.com/dc-js/dc.js/tree/input-filter We just need to fix those tests and this can go in. |
input filter looks to be a great feature to have in dc library. |
Hi @rrameshkumar76, I hope to merge this soon. If you want to help, you could try this PR, either by checking out the branch I linked above, or simply by pasting the code into your copy of dc.js. Then please leave a review here in the ticket: if it worked for your purpose, if you think anything is missing, etc. Thanks! |
This works for me. Is there a way to hook into changes to the inputFilter so I can redraw a datatables.js table? For other widgets I am hooking into dc.chartRegistry.list()[i].on("filtered") and the redrawing the table, is there an equivalent hook for a inputFilter? (currently using a hook on renderlet, but this has a noticeable delay) |
@tttp Thanks for your excellent work. I am currently working on upgrading dc to use D3v4 and assisting on preparing next major release of dc (version 3). You can track the progress in 3.0 branch. @gordonwoodhull has planned this PR to be part of this release. I will be working on upgrading this PR for D3v4 and readying for inclusion in dc. Will really appreciate if you are around and are able to help :) |
Please check #1387 |
Obsoleted by #1387 |
Thanks to the suggestion on github, added throttling. It turns out that the result is smooth enough by simply waiting until the 200ms, rather than complicating and offering the option to draw separately slow and faster graphs.
The spec needs better test, but I'd need some help, I'm a bit lost
I'd love if someone could comment on the feature itself, I'll figure out what makes sense to test soon I think