Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix split module from main package component in sub-packages optimization #2208

Merged
merged 1 commit into from
Oct 26, 2020
Merged

Fix split module from main package component in sub-packages optimization #2208

merged 1 commit into from
Oct 26, 2020

Conversation

huadong
Copy link

@huadong huadong commented Oct 22, 2020

Fixes #2196

fxy060608
fxy060608 reviewed Oct 22, 2020
View reviewed changes
Copy link
Collaborator

@fxy060608 fxy060608 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zhetengbiji 我看了下，应该没什么问题，可以确认合并下

@huadong
Copy link
Author

huadong commented Oct 26, 2020

PR到底应该在master上打还是在dev分支上打？

@zhetengbiji zhetengbiji merged commit 6016bd2 into dcloudio:dev Oct 26, 2020
@zhetengbiji
Copy link
Collaborator

PR到底应该在master上打还是在dev分支上打？

dev

已处理

@huadong huadong mentioned this pull request Dec 30, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fxy060608 fxy060608 fxy060608 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@huadong @zhetengbiji @fxy060608